[pve-devel] [PATCH] Add DNS challenge schema for knot.

[pve-devel] [PATCH] Add DNS challenge schema for knot.

[Jens Meißner]

Signed-off-by: Jens Meißner <meissner@b1-systems.de>
---
 src/dns-challenge-schema.json | 19 ++++++++++++++++++-
 1 file changed, 18 insertions(+), 1 deletion(-)

diff --git a/src/dns-challenge-schema.json b/src/dns-challenge-schema.json
index a3a3ebc..d194701 100644
--- a/src/dns-challenge-schema.json
+++ b/src/dns-challenge-schema.json
@@ -211,7 +211,24 @@
    },
    "kas" : {},
    "kinghost" : {},
-   "knot" : {},
+   "knot" : {
+      "fields" : {
+         "KNOT_SERVER" : {
+            "description" : "Hostname of the RFC 2136 compatible nameserver",
+            "type" : "string"
+         },
+         "KNOT_KEY" : {
+            "description" : "TSIG key (format alg:name:key)",
+            "type" : "string"
+         },
+         "KNOT_ZONE" : {
+            "description" : "DNS zone name (optional)",
+            "optional" : 1,
+            "type" : "string"
+         }
+      },
+      "name" : "Knot / knsupdate (RFC 2136)"
+   },
    "leaseweb" : {},
    "lexicon" : {},
    "linode" : {},
-- 
2.34.0

Re: [pve-devel] [PATCH] Add DNS challenge schema for knot.

[Thomas Lamprecht]

looks OK in general, one question inline...

On 17.11.21 09:03, Jens Meißner wrote:
> Signed-off-by: Jens Meißner <meissner@b1-systems.de>
> ---
>  src/dns-challenge-schema.json | 19 ++++++++++++++++++-
>  1 file changed, 18 insertions(+), 1 deletion(-)
> 
> diff --git a/src/dns-challenge-schema.json b/src/dns-challenge-schema.json
> index a3a3ebc..d194701 100644
> --- a/src/dns-challenge-schema.json
> +++ b/src/dns-challenge-schema.json
> @@ -211,7 +211,24 @@
>     },
>     "kas" : {},
>     "kinghost" : {},
> -   "knot" : {},
> +   "knot" : {
> +      "fields" : {
> +         "KNOT_SERVER" : {
> +            "description" : "Hostname of the RFC 2136 compatible nameserver",
> +            "type" : "string"
> +         },
> +         "KNOT_KEY" : {
> +            "description" : "TSIG key (format alg:name:key)",
> +            "type" : "string"
> +         },
> +         "KNOT_ZONE" : {

I did not find this variable being used anywhere in the acme.sh knot plugin[0], there's
only KNOT_SERVER and KNOT_KEY being accessed, so what's up with that one?

[1] https://git.proxmox.com/?p=mirror_acme.sh.git;a=blob;f=dnsapi/dns_knot.sh;hb=3.0.1

> +            "description" : "DNS zone name (optional)",
> +            "optional" : 1,
> +            "type" : "string"
> +         }
> +      },
> +      "name" : "Knot / knsupdate (RFC 2136)"
> +   },
>     "leaseweb" : {},
>     "lexicon" : {},
>     "linode" : {},
> 

Re: [pve-devel] [PATCH] Add DNS challenge schema for knot.

[Jens Meißner]

[-- Attachment #1.1: Type: text/plain, Size: 1780 bytes --]

Am 17.11.21 um 17:27 schrieb Thomas Lamprecht:
> looks OK in general, one question inline...
> 
> On 17.11.21 09:03, Jens Meißner wrote:
>> Signed-off-by: Jens Meißner <meissner@b1-systems.de>
>> ---
>>  src/dns-challenge-schema.json | 19 ++++++++++++++++++-
>>  1 file changed, 18 insertions(+), 1 deletion(-)
>>
>> diff --git a/src/dns-challenge-schema.json b/src/dns-challenge-schema.json
>> index a3a3ebc..d194701 100644
>> --- a/src/dns-challenge-schema.json
>> +++ b/src/dns-challenge-schema.json
>> @@ -211,7 +211,24 @@
>>     },
>>     "kas" : {},
>>     "kinghost" : {},
>> -   "knot" : {},
>> +   "knot" : {
>> +      "fields" : {
>> +         "KNOT_SERVER" : {
>> +            "description" : "Hostname of the RFC 2136 compatible nameserver",
>> +            "type" : "string"
>> +         },
>> +         "KNOT_KEY" : {
>> +            "description" : "TSIG key (format alg:name:key)",
>> +            "type" : "string"
>> +         },
>> +         "KNOT_ZONE" : {
> 
> I did not find this variable being used anywhere in the acme.sh knot plugin[0], there's
> only KNOT_SERVER and KNOT_KEY being accessed, so what's up with that one?
> 
> [1] https://git.proxmox.com/?p=mirror_acme.sh.git;a=blob;f=dnsapi/dns_knot.sh;hb=3.0.1

Hm, the parameter is documented but not used in code:
https://github.com/acmesh-official/acme.sh/wiki/dnsapi#19-use-knot-knsupdate-dns-api-to-automatically-issue-cert

I sent an updated patch without it.

>> +            "description" : "DNS zone name (optional)",
>> +            "optional" : 1,
>> +            "type" : "string"
>> +         }
>> +      },
>> +      "name" : "Knot / knsupdate (RFC 2136)"
>> +   },
>>     "leaseweb" : {},
>>     "lexicon" : {},
>>     "linode" : {},


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 263 bytes --]