[pve-devel] [PATCH manager] SDN: Rename VNet Alias to Comment in the UI

[pve-devel] [PATCH manager] SDN: Rename VNet Alias to Comment in the UI

[Stefan Lendl]

Make this consistent with PVE networking which has a Comment option.
Aliases used in VNet are basically comments if the id which is limited
to 8 chars is too long.

Signed-off-by: Stefan Lendl <s.lendl@proxmox.com>
---
 www/manager6/sdn/VnetEdit.js        | 2 +-
 www/manager6/sdn/VnetView.js        | 2 +-
 www/manager6/sdn/ZoneContentView.js | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/www/manager6/sdn/VnetEdit.js b/www/manager6/sdn/VnetEdit.js
index 0f55595f..12642f85 100644
--- a/www/manager6/sdn/VnetEdit.js
+++ b/www/manager6/sdn/VnetEdit.js
@@ -31,7 +31,7 @@ Ext.define('PVE.sdn.VnetInputPanel', {
 	{
 	    xtype: 'textfield',
 	    name: 'alias',
-	    fieldLabel: gettext('Alias'),
+	    fieldLabel: gettext('Comment'),
 	    allowBlank: true,
 	},
 	{
diff --git a/www/manager6/sdn/VnetView.js b/www/manager6/sdn/VnetView.js
index 3fd3c916..5c153f6b 100644
--- a/www/manager6/sdn/VnetView.js
+++ b/www/manager6/sdn/VnetView.js
@@ -93,7 +93,7 @@ Ext.define('PVE.sdn.VnetView', {
 		    },
 		},
 		{
-		    header: gettext('Alias'),
+		    header: gettext('Comment'),
 		    flex: 1,
 		    dataIndex: 'alias',
 		    renderer: function(value, metaData, rec) {
diff --git a/www/manager6/sdn/ZoneContentView.js b/www/manager6/sdn/ZoneContentView.js
index 2a3cbf52..107be97e 100644
--- a/www/manager6/sdn/ZoneContentView.js
+++ b/www/manager6/sdn/ZoneContentView.js
@@ -62,7 +62,7 @@ Ext.define('PVE.sdn.ZoneContentView', {
 		    dataIndex: 'vnet',
 		},
 		{
-		    header: 'Alias',
+		    header: 'Comment',
 		    width: 300,
 		    sortable: true,
 		    dataIndex: 'alias',
-- 
2.41.0

Re: [pve-devel] [PATCH manager] SDN: Rename VNet Alias to Comment in the UI

[Thomas Lamprecht]

Am 13/10/2023 um 13:03 schrieb Stefan Lendl:
> Make this consistent with PVE networking which has a Comment option.
> Aliases used in VNet are basically comments if the id which is limited
> to 8 chars is too long.

but comments have no effect, these have a real effect, this is set on
the interface and tracked by the kernel

Also, ifupdown2's interfaces names it alias as it's named alias also
in the kernel, so naming this "comment" here makes it harder to make
the actual connection to what this refers – I'd like to avoid such
things as it actually makes things less consistent..