From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Stefan Lendl <s.lendl@proxmox.com>
Subject: Re: [pve-devel] [PATCH manager] SDN: Rename VNet Alias to Comment in the UI
Date: Fri, 13 Oct 2023 13:21:52 +0200 [thread overview]
Message-ID: <378f352a-48aa-44f3-af5d-6866f92a8a14@proxmox.com> (raw)
In-Reply-To: <20231013110347.80854-1-s.lendl@proxmox.com>
Am 13/10/2023 um 13:03 schrieb Stefan Lendl:
> Make this consistent with PVE networking which has a Comment option.
> Aliases used in VNet are basically comments if the id which is limited
> to 8 chars is too long.
but comments have no effect, these have a real effect, this is set on
the interface and tracked by the kernel
Also, ifupdown2's interfaces names it alias as it's named alias also
in the kernel, so naming this "comment" here makes it harder to make
the actual connection to what this refers – I'd like to avoid such
things as it actually makes things less consistent..
prev parent reply other threads:[~2023-10-13 11:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-13 11:03 Stefan Lendl
2023-10-13 11:21 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=378f352a-48aa-44f3-af5d-6866f92a8a14@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=s.lendl@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox