From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Stefan Sterz <s.sterz@proxmox.com>
Subject: [pve-devel] applied: [PATCH pve-eslint] switch to using `Command.opts()` to access options
Date: Wed, 30 Aug 2023 11:39:08 +0200 [thread overview]
Message-ID: <377409fc-057b-464b-8ff9-a8ec6189e388@proxmox.com> (raw)
In-Reply-To: <20230830092429.108551-1-s.sterz@proxmox.com>
Am 30/08/2023 um 11:24 schrieb Stefan Sterz:
> this fixes an issue where the options where not properly passed to
> eslint, which rendered them useless. uses the `opts()` function to
> access them. see [1] for more on info on option parsing with
> commander.
>
> [1]: https://www.npmjs.com/package/commander#user-content-options
>
> Signed-off-by: Stefan Sterz <s.sterz@proxmox.com>
> ---
>
> not sure how we handle this, but might need a:
>
> Reported-by: Max Carrara <m.carrara@proxmox.com>
>
> src/bin/app.js | 29 +++++++++++++++--------------
> 1 file changed, 15 insertions(+), 14 deletions(-)
>
>
applied, thanks!
prev parent reply other threads:[~2023-08-30 9:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-30 9:24 [pve-devel] " Stefan Sterz
2023-08-30 9:39 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=377409fc-057b-464b-8ff9-a8ec6189e388@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=s.sterz@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox