From: David Riley <d.riley@proxmox.com>
To: Erik Fastermann <e.fastermann@proxmox.com>, pve-devel@lists.proxmox.com
Subject: Re: [PATCH pve-guest-common 1/3] fix #5713: vzdump: add notification-mode none
Date: Wed, 13 May 2026 12:22:42 +0200 [thread overview]
Message-ID: <36ef4020-1b61-4dbf-81fa-dbb2a7649a5a@proxmox.com> (raw)
In-Reply-To: <20260513072756.33226-2-e.fastermann@proxmox.com>
Small typo in the description.
On 5/13/26 9:26 AM, Erik Fastermann wrote:
> Optionally disable sending notification mails with the new option
> none for notification-mode in vzdump.
>
> This can be useful if you want to disable sending notifications for a
> specific backup job and not change the global notification settings or
> use the deprecated legacy sendmail with an empty address.
>
> Signed-off-by: Erik Fastermann <e.fastermann@proxmox.com>
> ---
> src/PVE/VZDump/Common.pm | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/src/PVE/VZDump/Common.pm b/src/PVE/VZDump/Common.pm
> index 67a4cf4..1c636b4 100644
> --- a/src/PVE/VZDump/Common.pm
> +++ b/src/PVE/VZDump/Common.pm
> @@ -261,9 +261,10 @@ my $confdesc = {
> . " specified address(es) via the 'sendmail' command. If set to 'notification-system',"
> . " a notification will be sent via PVE's notification system, and the mailto and"
> . " mailnotification will be ignored. If set to 'auto' (default setting), an email will"
> - . " be sent if mailto is set, and the notification system will be used if not.",
> + . " be sent if mailto is set, and the notification system will be used if not."
> + . " If set to 'none', no notification will be send.",
should be "sent" instead of "send".
> optional => 1,
> - enum => ['auto', 'legacy-sendmail', 'notification-system'],
> + enum => ['auto', 'legacy-sendmail', 'notification-system', 'none'],
> default => 'auto',
> },
> tmpdir => {
next prev parent reply other threads:[~2026-05-13 10:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-13 7:27 [PATCH guest-common/manager 0/3] fix #5713: vzdump: add notification-mode none Erik Fastermann
2026-05-13 7:27 ` [PATCH pve-guest-common 1/3] " Erik Fastermann
2026-05-13 10:22 ` David Riley [this message]
2026-05-13 7:27 ` [PATCH pve-manager 2/3] " Erik Fastermann
2026-05-13 7:27 ` [PATCH pve-manager 3/3] ui: " Erik Fastermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=36ef4020-1b61-4dbf-81fa-dbb2a7649a5a@proxmox.com \
--to=d.riley@proxmox.com \
--cc=e.fastermann@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox