From: Stefan Hanreich <s.hanreich@proxmox.com>
To: Fiona Ebner <f.ebner@proxmox.com>, pve-devel@lists.proxmox.com
Subject: Re: [pve-devel] [PATCH common] inotify: avoid cyclic use statement
Date: Mon, 11 Nov 2024 13:33:31 +0100 [thread overview]
Message-ID: <369a423b-57d7-4ad5-a9f8-4b758ca55c75@proxmox.com> (raw)
In-Reply-To: <75bd9a19-1194-4a9b-9191-b3ead256e152@proxmox.com>
On 11/11/24 13:10, Fiona Ebner wrote:
>>> The rest of the PVE::INotify module alredy uses syslog(), which could
>>> be used here as well to get rid of the cyclic usage. Wolfgang argued
>>> that the whole point of commit e68ebda was to remove coupling between
>>> the name and the type of the interface. If there still is some code
>>> about a name starting with 'vmbr' being classified wrong, that should
>>> rather be fixed. Because of the very commit, the frontend already
>>> doesn't show e.g. a non-bridge with name 'vmbr7' in bridge selectors.
>
> If we keep it, syslog() is better than warn here. But why is it better
> for the check to be there than not (like Wolfgang suggested)?
It was intended as a safety net, so we can catch potentially odd setups.
Iirc no one ever reported seeing that warning, so I guess it passed the
scream test.
So, removing this check is fine by me.
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2024-11-11 12:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-02 11:53 Fiona Ebner
2024-11-11 11:49 ` Stefan Hanreich
2024-11-11 12:10 ` Fiona Ebner
2024-11-11 12:33 ` Stefan Hanreich [this message]
2024-11-11 12:37 ` [pve-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=369a423b-57d7-4ad5-a9f8-4b758ca55c75@proxmox.com \
--to=s.hanreich@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox