public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Fiona Ebner <f.ebner@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>,
	Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH-SERIES v3 manager/docs] close #4513: add performance tab for backup jobs
Date: Tue, 16 Apr 2024 14:11:19 +0200	[thread overview]
Message-ID: <364a9ffc-526d-463c-8f88-7af276474cc0@proxmox.com> (raw)
In-Reply-To: <24e81908-5ae1-48c7-81a2-7fcb1a085be7@proxmox.com>

Am 16.04.24 um 12:16 schrieb Thomas Lamprecht:
> Am 25/03/2024 um 15:09 schrieb Fiona Ebner:
>> Am 07.11.23 um 14:49 schrieb Fiona Ebner:
>>> Improve fallback for the 'performance' sub-properties by using a
>>> per-property fallback and honor schema defaults.
>>>
>>> Expose commonly used performance-related properties in the backup job
>>> UI under a new tab.
>>>
>>
>> Ping. Still applies. I need to tell forum users how to do this via CLI
>> rather frequently, so would be nice to have in the UI too.
>>
> 
> I do not like using "Performance" here, that conveys that this includes
> important options that one must set to improve performance, and it's
> settings won't help with overall performance (buy a "faster" HW for that).
> 
> In short, while the name is not wrong in a technical sense, all knobs will
> change performance on some axis, that's not really matching with user
> expectations IMO.
> 
> Even just calling this "Options" would be better IMO, even better might
> be to call it "Advanced" and move also the single advanced option we
> currently have ("Repeat missed" in General tab) over there.
> 
> That way newer users are made aware off that these options are
> definitively not a must to adapt to get good performance, but rather for
> some advanced options for tuning/limiting/etc. ...

Sounds good to me. Sent a v4 incorporating these suggestions:
https://lists.proxmox.com/pipermail/pve-devel/2024-April/063004.html




      reply	other threads:[~2024-04-16 12:11 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-07 13:49 Fiona Ebner
2023-11-07 13:49 ` [pve-devel] [PATCH v3 manager 1/4] vzdump: actually honor schema defaults for performance Fiona Ebner
2023-11-07 13:49 ` [pve-devel] [PATCH v3 manager 2/4] vzdump: use per-property fallback for performance settings Fiona Ebner
2023-11-07 13:49 ` [pve-devel] [PATCH v3 manager 3/4] close #4513: ui: backup job: add performance tab Fiona Ebner
2023-11-07 13:49 ` [pve-devel] [PATCH v3 manager 4/4] ui: backup job: disable zstd thread count field when zstd isn't used Fiona Ebner
2023-11-07 13:49 ` [pve-devel] [PATCH v3 docs 5/5] backup: update information about performance settings Fiona Ebner
2024-03-25 14:09 ` [pve-devel] [PATCH-SERIES v3 manager/docs] close #4513: add performance tab for backup jobs Fiona Ebner
2024-04-16 10:16   ` Thomas Lamprecht
2024-04-16 12:11     ` Fiona Ebner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=364a9ffc-526d-463c-8f88-7af276474cc0@proxmox.com \
    --to=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    --cc=t.lamprecht@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal