From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Fiona Ebner <f.ebner@proxmox.com>
Subject: [pve-devel] applied-series: [PATCH qemu-server 1/2] backup: prepare: fix format detection for disks without storage ID
Date: Mon, 27 Mar 2023 11:40:13 +0200 [thread overview]
Message-ID: <36395eaa-d50c-7fb9-7ac2-47458debddcb@proxmox.com> (raw)
In-Reply-To: <20230327090106.15803-1-f.ebner@proxmox.com>
Am 27/03/2023 um 11:01 schrieb Fiona Ebner:
> which is the case for passed-through disks. The qemu_img_format()
> function cannot correctly handle those, and it's not safe to assume
> they are raw (it's most likely, but not guaranteed), so just use the
> storage method for the format like it was done before commit
> efa3aa24 ("avoid list context for volume_size_info calls"). This will
> use 'qemu-img info' to get the actual format.
>
> Reported in the community forum:
> https://forum.proxmox.com/threads/124794/
> https://forum.proxmox.com/threads/124823/
> https://forum.proxmox.com/threads/124818/
>
> Fixes: efa3aa24 ("avoid list context for volume_size_info calls")
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
> ---
> PVE/VZDump/QemuServer.pm | 17 +++++++++++++----
> 1 file changed, 13 insertions(+), 4 deletions(-)
>
>
applied both patches with Friedrich's T-b, thanks!
prev parent reply other threads:[~2023-03-27 9:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-27 9:01 [pve-devel] " Fiona Ebner
2023-03-27 9:01 ` [pve-devel] [PATCH qemu-server 2/2] backup: prepare: improve error messages Fiona Ebner
2023-03-27 9:35 ` [pve-devel] [PATCH qemu-server 1/2] backup: prepare: fix format detection for disks without storage ID Friedrich Weber
2023-03-27 9:40 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=36395eaa-d50c-7fb9-7ac2-47458debddcb@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox