Re: [pve-devel] [PATCH v4 manager 0/4] vzdump: add 'notification-mode' parameter

[Philipp Hufnagl <p.hufnagl@proxmox.com>]

On 11/21/23 13:52, Lukas Wagner wrote:
> This patch series adds the 'notification-mode' setting for backup jobs.
> It allows users to choose between the 'old-style' notifications 
> (mail to configured address, directly via a call to sendmail) or 
> the 'new-style' notification system.
> 
> notification-mode has three possible values:
>   - legacy-sendmail: Use old system, considering mailto/mailtnotification parameters
>   - notification-system: Use the new system (always sending a notification, irregardless 
>     of success/failure. The user is supposed to configure filtering/matching in 
>     notification settings)
>   - auto: use old system if mailto is set, or new system if not
> 
> This should provide a fix/workaround for the users' reports of
>   - double notifications (these happened in case mailto was set to the same address
>     as root@pam)
>   - notifications always being sent, even if 'mailnotification' is set to failure
> 
> Changes v2 -> v3:
>   - change field text in the GUI for the 'mailnotification' param
>     This should highlight that this setting only affects the 'legacy-sendmail' 
>     notification mails
> 
> Changes v3 -> v4:
>   - fix eslint warnings (thx @Philipp)
>   - drop already applied pve-guest-common patch
> 
> 
> 
> pve-manager:
> 
> Lukas Wagner (4):
>   vzdump: support 'notification-mode' parameter
>   ui: backup jobs: add 'notification-mode' selector for backup jobs
>   ui: backup: add 'notification-mode' param for one-shot backup jobs.
>   ui: backup job: change field text for 'mailnotification' field
> 
>  PVE/VZDump.pm                                 | 95 +++++++++++--------
>  www/manager6/dc/Backup.js                     | 34 ++++++-
>  .../form/NotificationPolicySelector.js        |  2 +-
>  www/manager6/window/Backup.js                 | 25 +++++
>  4 files changed, 116 insertions(+), 40 deletions(-)
> 
> 
> Summary over all repositories:
>   4 files changed, 116 insertions(+), 40 deletions(-)
> 

I do not know if this is expected but when I enter an invalid email
address for a user, and then press "Test" for SMTP, I get a message
that the email has been sent successfully, however the receiver does
not get any email and the sender account gets "Undelivered Mail
Returned to Sender".