From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Daniel Kral <d.kral@proxmox.com>
Subject: [pve-devel] applied: [PATCH qemu-server v2] vm_start: add syslog info with which PID a VM was started
Date: Sun, 10 Nov 2024 20:16:56 +0100 [thread overview]
Message-ID: <35053f2d-5940-4a15-aaa2-aab763e0f5a0@proxmox.com> (raw)
In-Reply-To: <20241023095543.57202-1-d.kral@proxmox.com>
Am 23.10.24 um 11:55 schrieb Daniel Kral:
> Adds a syslog entry to log the process id that has been given to the
> QEMU VM process at start. This is helpful debugging information if the
> pid shows up at other places, like a kernel stack trace, while the VM
> has been running, but cannot be retrieved anymore (e.g. the pidfile has
> been deleted or only the syslog is available).
>
> The syslog has been put in the `PVE::QemuServer::vm_start_nolock`
> subroutine to make sure that the PID is logged not only when the VM has
> been started by the API endpoint `vm_start`, but also when the VM is
> started by a remote migration.
>
> Suggested-by: Hannes Dürr <h.duerr@proxmox.com>
> Suggested-by: Friedrich Weber <f.weber@proxmox.com>
> Signed-off-by: Daniel Kral <d.kral@proxmox.com>
> ---
> Differences to v1:
> - Fix commit message trailer order
> - Uppercase PID in syslog message
>
> PVE/QemuServer.pm | 3 +++
> 1 file changed, 3 insertions(+)
>
>
applied, with Daniel Herzig's R-b, thanks!
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2024-11-10 19:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-23 9:55 [pve-devel] " Daniel Kral
2024-10-28 7:49 ` Daniel Herzig
2024-11-10 19:16 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=35053f2d-5940-4a15-aaa2-aab763e0f5a0@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.kral@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox