[pve-devel] [PATCH manager] pvereport: add `date -R` to general system info section

[pve-devel] [PATCH manager] pvereport: add `date -R` to general system info section

[Lukas Wagner]

Sometimes it can be quite useful to know when exactly a system report
was generated. Adds the following output quite prominently in the
general system info section:

 # date -R
 Thu, 23 Feb 2023 16:21:12 +0100

Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
---
 PVE/Report.pm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/PVE/Report.pm b/PVE/Report.pm
index d363c15b..c9109dca 100644
--- a/PVE/Report.pm
+++ b/PVE/Report.pm
@@ -29,6 +29,7 @@ my $init_report_cmds = sub {
 	    order => 10,
 	    cmds => [
 		'hostname',
+		'date -R',
 		'pveversion --verbose',
 		'cat /etc/hosts',
 		'pvesubscription get',
-- 
2.30.2

Re: [pve-devel] [PATCH manager] pvereport: add `date -R` to general system info section

[Stefan Sterz]

On 2/23/23 16:25, Lukas Wagner wrote:
> Sometimes it can be quite useful to know when exactly a system report
> was generated. Adds the following output quite prominently in the
> general system info section:
>

While I agree that this can be useful sometimes, just as a heads-up,
iptables-save provides that info already:

# Generated by iptables-save v1.8.7 on Thu Feb 23 16:43:26 2023

However, we may not want to rely on that.

>  # date -R
>  Thu, 23 Feb 2023 16:21:12 +0100
> 
> Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
> ---
>  PVE/Report.pm | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/PVE/Report.pm b/PVE/Report.pm
> index d363c15b..c9109dca 100644
> --- a/PVE/Report.pm
> +++ b/PVE/Report.pm
> @@ -29,6 +29,7 @@ my $init_report_cmds = sub {
>  	    order => 10,
>  	    cmds => [
>  		'hostname',
> +		'date -R',
>  		'pveversion --verbose',
>  		'cat /etc/hosts',
>  		'pvesubscription get',

Re: [pve-devel] [PATCH manager] pvereport: add `date -R` to general system info section

[Lukas Wagner]

On 2/23/23 16:54, Stefan Sterz wrote:
> While I agree that this can be useful sometimes, just as a heads-up,
> iptables-save provides that info already:
> 
> # Generated by iptables-save v1.8.7 on Thu Feb 23 16:43:26 2023
> 
> However, we may not want to rely on that.
> 

Thanks for the feedback!
I am aware of the iptables output, I just thought it would be nice to have the
"tuple" (hostname, date) right at the start. Additionally, I have submitted patches
for PBS and PMG as well, to have the same info for all three products.

-- 
- Lukas

Re: [pve-devel] [PATCH manager] pvereport: add `date -R` to general system info section

[Lukas Wagner]

On 2/23/23 16:25, Lukas Wagner wrote:
> Sometimes it can be quite useful to know when exactly a system report
> was generated. Adds the following output quite prominently in the
> general system info section:
> 
>   # date -R
>   Thu, 23 Feb 2023 16:21:12 +0100
> 
> Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
> ---
>   PVE/Report.pm | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/PVE/Report.pm b/PVE/Report.pm
> index d363c15b..c9109dca 100644
> --- a/PVE/Report.pm
> +++ b/PVE/Report.pm
> @@ -29,6 +29,7 @@ my $init_report_cmds = sub {
>   	    order => 10,
>   	    cmds => [
>   		'hostname',
> +		'date -R',
>   		'pveversion --verbose',
>   		'cat /etc/hosts',
>   		'pvesubscription get',

Ping. The same change was already merged into PBS and PMG, so it would be good to have it
in PVE system reports as well.

-- 
- Lukas

[pve-devel] applied: [PATCH manager] pvereport: add `date -R` to general system info section

[Thomas Lamprecht]

Am 23/02/2023 um 16:25 schrieb Lukas Wagner:
> Sometimes it can be quite useful to know when exactly a system report
> was generated. Adds the following output quite prominently in the
> general system info section:
> 
>  # date -R
>  Thu, 23 Feb 2023 16:21:12 +0100
> 
> Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
> ---
>  PVE/Report.pm | 1 +
>  1 file changed, 1 insertion(+)
> 
>

applied, thanks!