* [pve-devel] [PATCH qemu-server] snapshot: save VM state: propagate error from QEMU
@ 2022-08-29 10:54 Fiona Ebner
2022-08-30 10:46 ` [pve-devel] applied: " Thomas Lamprecht
0 siblings, 1 reply; 2+ messages in thread
From: Fiona Ebner @ 2022-08-29 10:54 UTC (permalink / raw)
To: pve-devel
So that there is a better chance to debug issues like in [0]. For
suspending, which uses the same QMP calls, this is already done.
[0]: https://forum.proxmox.com/threads/114203/
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
PVE/QemuConfig.pm | 3 +++
1 file changed, 3 insertions(+)
diff --git a/PVE/QemuConfig.pm b/PVE/QemuConfig.pm
index cfef8d37..b75227b5 100644
--- a/PVE/QemuConfig.pm
+++ b/PVE/QemuConfig.pm
@@ -327,6 +327,9 @@ sub __snapshot_create_vol_snapshots_hook {
my ($b, $t) = $render_state->($stat);
print "completed saving the VM state in $t, saved $b\n";
last;
+ } elsif ($stat->{status} eq 'failed') {
+ my $err = $stat->{error} || 'unknown error';
+ die "unable to save VM state and RAM - $err\n";
} else {
die "query-savevm returned unexpected status '$stat->{status}'\n";
}
--
2.30.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* [pve-devel] applied: [PATCH qemu-server] snapshot: save VM state: propagate error from QEMU
2022-08-29 10:54 [pve-devel] [PATCH qemu-server] snapshot: save VM state: propagate error from QEMU Fiona Ebner
@ 2022-08-30 10:46 ` Thomas Lamprecht
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2022-08-30 10:46 UTC (permalink / raw)
To: Proxmox VE development discussion, Fiona Ebner
Am 29/08/2022 um 12:54 schrieb Fiona Ebner:
> So that there is a better chance to debug issues like in [0]. For
> suspending, which uses the same QMP calls, this is already done.
>
> [0]: https://forum.proxmox.com/threads/114203/
>
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
> ---
> PVE/QemuConfig.pm | 3 +++
> 1 file changed, 3 insertions(+)
>
>
applied, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-08-30 10:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-29 10:54 [pve-devel] [PATCH qemu-server] snapshot: save VM state: propagate error from QEMU Fiona Ebner
2022-08-30 10:46 ` [pve-devel] applied: " Thomas Lamprecht
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox