public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Aaron Lauterer <a.lauterer@proxmox.com>
Subject: [pve-devel] applied: [PATCH v2 storage 3/3] rbd: add integration test for namespace handling
Date: Mon, 12 Apr 2021 14:48:29 +0200	[thread overview]
Message-ID: <3453bc44-ebf2-d186-6b40-c335a231c9d8@proxmox.com> (raw)
In-Reply-To: <20210407142218.29156-4-a.lauterer@proxmox.com>

On 07.04.21 16:22, Aaron Lauterer wrote:
> This test is intended to be run on a hyperconverged PVE cluster to test
> the most common operations of VMs using a namespaced Ceph RBD pool.
> 
> Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
> ---
> v1 -> v2:
> reworked the test from the feedback I got [0].
> 
> * tests are now defined in deeper hashes/arrays and can contain testing
>   steps as well as preparation and cleanup steps where needed.
> * command calls don't use fixed paths
> * command calls use arrays
> * a new Ceph pool will be created and removed at the end by default. Can
>   be overriden with the '--use_existing' parameter. Most likely in
>   combination with the '--pool' parameter.
> * debug flag has been introduced to be used if some debug printing via
>   the `jp` sub is needed. Currenctly not used but might be useful when
>   tinkering with the test in the future. Thx @Thomas for the hint
> 
> 
> [0] https://lists.proxmox.com/pipermail/pve-devel/2021-April/047472.html
> 
>  test/rbd_namespace.pl | 370 ++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 370 insertions(+)
>  create mode 100755 test/rbd_namespace.pl
> 
>

applied, thanks!

I made three small follow-ups though:

* switched --use_existing to --use-existing
* exit cleanly on --help, its not an error after all!
* allow also the short-opt version for help, -h




      reply	other threads:[~2021-04-12 12:49 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-07 14:22 [pve-devel] [PATCH v2 storage 0/3] ceph: add namespace support Aaron Lauterer
2021-04-07 14:22 ` [pve-devel] [PATCH v2 storage 1/3] rbd: centralize rbd path concatenation Aaron Lauterer
2021-04-12 12:39   ` [pve-devel] applied: " Thomas Lamprecht
2021-04-07 14:22 ` [pve-devel] [PATCH v2 storage 2/3] rbd: fix #3286 add namespace support Aaron Lauterer
2021-04-12 12:41   ` [pve-devel] applied: " Thomas Lamprecht
2021-04-07 14:22 ` [pve-devel] [PATCH v2 storage 3/3] rbd: add integration test for namespace handling Aaron Lauterer
2021-04-12 12:48   ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3453bc44-ebf2-d186-6b40-c335a231c9d8@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=a.lauterer@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal