public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Maximiliano Sandoval <m.sandoval@proxmox.com>,
	Friedrich Weber <f.weber@proxmox.com>
Cc: pve-devel@lists.proxmox.com
Subject: Re: [PATCH pve-cluster 2/2] api: cluster config: create new clusters with lower token coefficient
Date: Mon, 16 Feb 2026 20:36:54 +0100	[thread overview]
Message-ID: <33fcd2fb-48b2-44a2-9e34-e1511d6101de@proxmox.com> (raw)
In-Reply-To: <s8ocy247k6a.fsf@proxmox.com>

Am 16.02.26 um 17:00 schrieb Maximiliano Sandoval:
>> +            'token-coefficient' => {
>> +                type => 'integer',
>> +                description => "Token coefficient to set in the corosync configuration.",
>> +                default => 125,
>> +                minimum => 0,
>>From man 5 corosync.conf's token_coefficient documentation: "This value
> can be set to 0 resulting in effective removal of this feature.". If we
> want to expose setting this to 0 I would document that it has a special
> meaning and what does this entail. I would personally feel more
> comfortable setting `minimum => 1` for now instead.

At least a "see `man 5 corosync.conf` for details might be nice, adding some
extra hints here, like how it's roughly used and special values, could be
indeed nice too; some of that might be better off in the docs or the
verbose_descriptions property though.

But I'm not so sure about the actual value to the user of restricting this
here? I mean, if we ever would expose this in the UI in some advanced section
then one could show clear hints for such special/odd values and their potential
implications, for the CLI that's mostly the job of the docs and maybe an extra
informal "log" print, but forcing a user editing the corosync.conf manually in
case they want to try this, whyever that might be, seems to rather worsen UX not
improve it.




  reply	other threads:[~2026-02-16 19:36 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-12 11:57 [PATCH cluster/docs 0/3] create new corosync " Friedrich Weber
2026-02-12 11:57 ` [PATCH pve-cluster 1/2] corosync: create config: allow setting " Friedrich Weber
2026-02-12 11:57 ` [PATCH pve-cluster 2/2] api: cluster config: create new clusters with lower " Friedrich Weber
2026-02-16 16:00   ` Maximiliano Sandoval
2026-02-16 19:36     ` Thomas Lamprecht [this message]
2026-02-17 12:44       ` Maximiliano Sandoval
2026-02-17 12:50         ` Friedrich Weber
2026-02-16 16:09   ` Maximiliano Sandoval
2026-02-12 11:57 ` [PATCH pve-docs 1/1] pvecm: config: document how to change the " Friedrich Weber
2026-02-13 10:12   ` Friedrich Weber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=33fcd2fb-48b2-44a2-9e34-e1511d6101de@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=f.weber@proxmox.com \
    --cc=m.sandoval@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal