From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Mira Limbeck <m.limbeck@proxmox.com>
Subject: [pve-devel] applied: [PATCH v3 proxmox-openid-rs] fix Open ID with Azure as provider
Date: Fri, 1 Apr 2022 16:02:01 +0200 [thread overview]
Message-ID: <33fa70ae-d2a9-845f-a482-1bd1a1409583@proxmox.com> (raw)
In-Reply-To: <20220401094425.158181-1-m.limbeck@proxmox.com>
On 01.04.22 11:44, Mira Limbeck wrote:
> Azure doesn't accept `Transfer-Encoding: chunked` on their token endpoint,
> but with the switch to ureq we always send requests with this set.
>
> Fix by switching to `Content-Length` in the header instead. ureq only
> sets `Transfer-Encoding: chunked` when the body length is not known
> beforehand, which is the case when using `send`. See
> https://docs.rs/ureq/2.4.0/ureq/index.html#content-length-and-transfer-encoding
>
> See https://forum.proxmox.com/threads/openid-401-with-azure-ad.105892/
> for the issue.
>
> Signed-off-by: Mira Limbeck <m.limbeck@proxmox.com>
> ---
> v3:
> - fixed link in inline comment
>
> v2:
> - added inline comment
> - removed the unnecessary `let bytes = ...` line
> - changed link in commit message to versioned docs.rs
>
> probably also fixes https://bugzilla.proxmox.com/show_bug.cgi?id=3916,
> but I could only reproduce this exact error message with Azure until
> now.
>
> src/http_client.rs | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
>
great find!
applied, many thanks!
prev parent reply other threads:[~2022-04-01 14:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-01 9:44 [pve-devel] " Mira Limbeck
2022-04-01 14:02 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=33fa70ae-d2a9-845f-a482-1bd1a1409583@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=m.limbeck@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox