[pve-devel] [PATCH manager 1/2] ui: storage: change CIFS to SMB/CIFS

[pve-devel] [PATCH manager 1/2] ui: storage: change CIFS to SMB/CIFS

[Aaron Lauterer]

This will hopefully help people to find the needed storage as not
everyone will be aware of the fact that CIFS is also a name used for it
(technically it was only SMB v1).

Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
---
 www/manager6/Utils.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/www/manager6/Utils.js b/www/manager6/Utils.js
index 71e5fc9a..5821cd9e 100644
--- a/www/manager6/Utils.js
+++ b/www/manager6/Utils.js
@@ -793,7 +793,7 @@ Ext.define('PVE.Utils', {
 	    backups: true,
 	},
 	cifs: {
-	    name: 'CIFS',
+	    name: 'SMB/CIFS',
 	    ipanel: 'CIFSInputPanel',
 	    faIcon: 'building',
 	    backups: true,
-- 
2.30.2

[pve-devel] [PATCH manager 2/2] ui: lxc options: change CIFS to SMB/CIFS

[Aaron Lauterer]

For consistency with the Storage panel and it might also help people to
make the connection if they are not aware that CIFS is a name used for
SMB.

Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
---
 www/manager6/lxc/FeaturesEdit.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/www/manager6/lxc/FeaturesEdit.js b/www/manager6/lxc/FeaturesEdit.js
index 807c2623..bce6e5fb 100644
--- a/www/manager6/lxc/FeaturesEdit.js
+++ b/www/manager6/lxc/FeaturesEdit.js
@@ -49,7 +49,7 @@ Ext.define('PVE.lxc.FeaturesInputPanel', {
 	{
 	    xtype: 'proxmoxcheckbox',
 	    name: 'cifs',
-	    fieldLabel: 'CIFS',
+	    fieldLabel: 'SMB/CIFS',
 	    bind: {
 		disabled: '{unprivileged}',
 		boxLabel: '{privilegedOnly}',
-- 
2.30.2

[pve-devel] applied: [PATCH manager 1/2] ui: storage: change CIFS to SMB/CIFS

[Thomas Lamprecht]

On 04.10.21 12:25, Aaron Lauterer wrote:
> This will hopefully help people to find the needed storage as not
> everyone will be aware of the fact that CIFS is also a name used for it
> (technically it was only SMB v1).

> 
> Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
> ---
>  www/manager6/Utils.js | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
>

applied both patches, thanks!

As they do one thing, i.e., switching "CIFS" to "SMB/CIFS" in the ui it would
be fine, or rather even better, in one patch. But, as people rather tend to throw
everything together and squashing is easier than splitting on review take it not
as direct/big complaint ;-)

Re: [pve-devel] applied: [PATCH manager 1/2] ui: storage: change CIFS to SMB/CIFS

[Aaron Lauterer]

On 10/5/21 07:41, Thomas Lamprecht wrote:
> On 04.10.21 12:25, Aaron Lauterer wrote:
>> This will hopefully help people to find the needed storage as not
>> everyone will be aware of the fact that CIFS is also a name used for it
>> (technically it was only SMB v1).
> 
>>
>> Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
>> ---
>>   www/manager6/Utils.js | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>>
> 
> applied both patches, thanks!
> 
> As they do one thing, i.e., switching "CIFS" to "SMB/CIFS" in the ui it would
> be fine, or rather even better, in one patch. But, as people rather tend to throw
> everything together and squashing is easier than splitting on review take it not
> as direct/big complaint ;-)

Hehehe, yeah, I was thinking exactly about that and then decided to err on the more verbose side ;)
>