From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Aaron Lauterer <a.lauterer@proxmox.com>
Subject: [pve-devel] applied: [PATCH manager 1/2] ui: storage: change CIFS to SMB/CIFS
Date: Tue, 5 Oct 2021 07:41:21 +0200 [thread overview]
Message-ID: <33f2b862-8cad-10ac-a882-62de69574346@proxmox.com> (raw)
In-Reply-To: <20211004102543.676413-1-a.lauterer@proxmox.com>
On 04.10.21 12:25, Aaron Lauterer wrote:
> This will hopefully help people to find the needed storage as not
> everyone will be aware of the fact that CIFS is also a name used for it
> (technically it was only SMB v1).
>
> Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
> ---
> www/manager6/Utils.js | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
applied both patches, thanks!
As they do one thing, i.e., switching "CIFS" to "SMB/CIFS" in the ui it would
be fine, or rather even better, in one patch. But, as people rather tend to throw
everything together and squashing is easier than splitting on review take it not
as direct/big complaint ;-)
next prev parent reply other threads:[~2021-10-05 5:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-04 10:25 [pve-devel] " Aaron Lauterer
2021-10-04 10:25 ` [pve-devel] [PATCH manager 2/2] ui: lxc options: " Aaron Lauterer
2021-10-05 5:41 ` Thomas Lamprecht [this message]
2021-10-05 6:34 ` [pve-devel] applied: [PATCH manager 1/2] ui: storage: " Aaron Lauterer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=33f2b862-8cad-10ac-a882-62de69574346@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=a.lauterer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox