Re: [pve-devel] [PATCH installer 10/14] auto-installer: tests: replace left/right with got/expected in output

From: Stefan Hanreich <s.hanreich@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Christoph Heiss <c.heiss@proxmox.com>
Subject: Re: [pve-devel] [PATCH installer 10/14] auto-installer: tests: replace left/right with got/expected in output
Date: Thu, 11 Jul 2024 17:03:11 +0200	[thread overview]
Message-ID: <33c5a51a-c393-4a2e-ba4b-1e81c2a58a8a@proxmox.com> (raw)
In-Reply-To: <20240710132756.1149508-11-c.heiss@proxmox.com>

On 7/10/24 15:27, Christoph Heiss wrote:
> Makes more sense and makes debugging easier.
> 
> Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
> ---
>  proxmox-auto-installer/tests/parse-answer.rs | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/proxmox-auto-installer/tests/parse-answer.rs b/proxmox-auto-installer/tests/parse-answer.rs
> index 450915a..81079b8 100644
> --- a/proxmox-auto-installer/tests/parse-answer.rs
> +++ b/proxmox-auto-installer/tests/parse-answer.rs
> @@ -77,7 +77,7 @@ fn test_parse_answers() {
>              let compare: Value = serde_json::from_str(&compare_raw).unwrap();
>              if config != compare {
>                  panic!(
> -                    "Test {} failed:\nleft:  {:#?}\nright: {:#?}\n",
> +                    "Test {} failed:\ngot: {:#?}\nexpected: {:#?}\n",
>                      name, config, compare
>                  );
>              }

maybe use assert_eq!() here altogether?

Also above in the file use assert!(!runtime_info.disks.is_empty()) ?

_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel