[pve-devel] [PATCH installer] first-boot: multi-user: start after pveproxy.service

[pve-devel] [PATCH installer] first-boot: multi-user: start after pveproxy.service

[Christoph Heiss]

First of, multi-user.target does not seem to really provide any (strong)
ordering guarantee, it seems.

Instead, let the "fully-up" ordering from the auto-installer depend on
pveproxy.service instead.

That way, it is ensured that 1) the system really is fully up and 2)
that users could even use the API / CLI commands, or write files to
pmxcfs.

Suggested-by: Shannon Sterz <s.sterz@proxmox.com>
Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
---
 proxmox-first-boot/etc/proxmox-first-boot-multi-user.service | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/proxmox-first-boot/etc/proxmox-first-boot-multi-user.service b/proxmox-first-boot/etc/proxmox-first-boot-multi-user.service
index d3c798d..4b30e7e 100644
--- a/proxmox-first-boot/etc/proxmox-first-boot-multi-user.service
+++ b/proxmox-first-boot/etc/proxmox-first-boot-multi-user.service
@@ -1,6 +1,7 @@
 [Unit]
 Description=Proxmox First Boot Setup (Fully Booted)
-After=systemd-remount-fs.service
+After=systemd-remount-fs.service pveproxy.service
+Wants=pveproxy.service
 ConditionPathExists=/var/lib/proxmox-first-boot/pending-first-boot-setup
 ConditionPathIsReadWrite=/var/lib
 
-- 
2.47.0



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH installer] first-boot: multi-user: start after pveproxy.service

[Thomas Lamprecht]

Am 19.11.24 um 15:39 schrieb Christoph Heiss:
> First of, multi-user.target does not seem to really provide any (strong)
> ordering guarantee, it seems.
> 
> Instead, let the "fully-up" ordering from the auto-installer depend on
> pveproxy.service instead.
> 
> That way, it is ensured that 1) the system really is fully up and 2)
> that users could even use the API / CLI commands, or write files to
> pmxcfs.
> 
> Suggested-by: Shannon Sterz <s.sterz@proxmox.com>
> Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
> ---
>  proxmox-first-boot/etc/proxmox-first-boot-multi-user.service | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/proxmox-first-boot/etc/proxmox-first-boot-multi-user.service b/proxmox-first-boot/etc/proxmox-first-boot-multi-user.service
> index d3c798d..4b30e7e 100644
> --- a/proxmox-first-boot/etc/proxmox-first-boot-multi-user.service
> +++ b/proxmox-first-boot/etc/proxmox-first-boot-multi-user.service
> @@ -1,6 +1,7 @@
>  [Unit]
>  Description=Proxmox First Boot Setup (Fully Booted)
> -After=systemd-remount-fs.service
> +After=systemd-remount-fs.service pveproxy.service
> +Wants=pveproxy.service

do we already want to add the units of the API from our other products now
already?

>  ConditionPathExists=/var/lib/proxmox-first-boot/pending-first-boot-setup
>  ConditionPathIsReadWrite=/var/lib
>  



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH installer] first-boot: multi-user: start after pveproxy.service

[Christoph Heiss]

On Tue, Nov 19, 2024 at 03:50:47PM +0100, Thomas Lamprecht wrote:
> Am 19.11.24 um 15:39 schrieb Christoph Heiss:
> > [..]
> > diff --git a/proxmox-first-boot/etc/proxmox-first-boot-multi-user.service b/proxmox-first-boot/etc/proxmox-first-boot-multi-user.service
> > index d3c798d..4b30e7e 100644
> > --- a/proxmox-first-boot/etc/proxmox-first-boot-multi-user.service
> > +++ b/proxmox-first-boot/etc/proxmox-first-boot-multi-user.service
> > @@ -1,6 +1,7 @@
> >  [Unit]
> >  Description=Proxmox First Boot Setup (Fully Booted)
> > -After=systemd-remount-fs.service
> > +After=systemd-remount-fs.service pveproxy.service
> > +Wants=pveproxy.service
>
> do we already want to add the units of the API from our other products now
> already?

Right, was a bit to quick for my own good with this.

Makes sense, I'll test that and send a v2 shortly.



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel