From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Christoph Heiss <c.heiss@proxmox.com>
Subject: Re: [pve-devel] [PATCH installer] first-boot: multi-user: start after pveproxy.service
Date: Tue, 19 Nov 2024 15:50:47 +0100 [thread overview]
Message-ID: <33b7c853-6386-43d0-97bb-11623d9471d0@proxmox.com> (raw)
In-Reply-To: <20241119143946.370202-1-c.heiss@proxmox.com>
Am 19.11.24 um 15:39 schrieb Christoph Heiss:
> First of, multi-user.target does not seem to really provide any (strong)
> ordering guarantee, it seems.
>
> Instead, let the "fully-up" ordering from the auto-installer depend on
> pveproxy.service instead.
>
> That way, it is ensured that 1) the system really is fully up and 2)
> that users could even use the API / CLI commands, or write files to
> pmxcfs.
>
> Suggested-by: Shannon Sterz <s.sterz@proxmox.com>
> Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
> ---
> proxmox-first-boot/etc/proxmox-first-boot-multi-user.service | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/proxmox-first-boot/etc/proxmox-first-boot-multi-user.service b/proxmox-first-boot/etc/proxmox-first-boot-multi-user.service
> index d3c798d..4b30e7e 100644
> --- a/proxmox-first-boot/etc/proxmox-first-boot-multi-user.service
> +++ b/proxmox-first-boot/etc/proxmox-first-boot-multi-user.service
> @@ -1,6 +1,7 @@
> [Unit]
> Description=Proxmox First Boot Setup (Fully Booted)
> -After=systemd-remount-fs.service
> +After=systemd-remount-fs.service pveproxy.service
> +Wants=pveproxy.service
do we already want to add the units of the API from our other products now
already?
> ConditionPathExists=/var/lib/proxmox-first-boot/pending-first-boot-setup
> ConditionPathIsReadWrite=/var/lib
>
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2024-11-19 14:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-19 14:39 Christoph Heiss
2024-11-19 14:50 ` Thomas Lamprecht [this message]
2024-11-19 15:03 ` Christoph Heiss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=33b7c853-6386-43d0-97bb-11623d9471d0@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=c.heiss@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox