From: Arthur Bied-Charreton <a.bied-charreton@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: Re: [PATCH qemu-server] fix #7705: blockdev: detach backing chain on disk move/hot-unplug
Date: Mon, 15 Jun 2026 11:56:13 +0200 [thread overview]
Message-ID: <33amip677utiqrzl6lovz6uk4cugclc263iul73cwbf5gl72d5@dkdvvvb7zkjm> (raw)
In-Reply-To: <20260615073406.165751-1-a.bied-charreton@proxmox.com>
On Mon, Jun 15, 2026 at 09:34:06AM +0200, Arthur Bied-Charreton wrote:
> When snapshots-as-volume-chains is enabled, moving or hot-unplugging a
> disk that holds snapshots does not detach the snapshot volumes.
> `Blockdev::detach` is called in both paths and only follows the `file`
> child, so the snapshot nodes are left behind. Since they were added
> explicitly via blockdev-add, they are also not GCed by QEMU and, as a
> result, keep their source volumes open.
>
> Deleting one of those snapshots after the move does not detach the
> orphaned block node because the disk is no longer attached to the
> running VM. QEMU keeps the volume open for as long as the VM runs, and a
> later attempt to remove the source fails with lvremove reporting the LV
> as still in use.
Forgot to mention that here but the bug report [0] includes a
reproducer, should fail before the fix and work afterwards :)
[0] https://bugzilla.proxmox.com/show_bug.cgi?id=7705
prev parent reply other threads:[~2026-06-15 9:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-15 7:34 [PATCH qemu-server] fix #7705: blockdev: detach backing chain on disk move/hot-unplug Arthur Bied-Charreton
2026-06-15 9:56 ` Arthur Bied-Charreton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=33amip677utiqrzl6lovz6uk4cugclc263iul73cwbf5gl72d5@dkdvvvb7zkjm \
--to=a.bied-charreton@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox