Re: [pve-devel] [PATCH common 1/5] fix #3900: schema: support and prefer sizes with verbose suffixes {K, M, G, T}iB

From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Fiona Ebner <f.ebner@proxmox.com>
Subject: Re: [pve-devel] [PATCH common 1/5] fix #3900: schema: support and prefer sizes with verbose suffixes {K, M, G, T}iB
Date: Sun, 1 Jun 2025 11:48:36 +0200	[thread overview]
Message-ID: <3307fd93-89bc-4a66-9ad2-08dac89b119b@proxmox.com> (raw)
In-Reply-To: <20250512124129.91914-2-f.ebner@proxmox.com>

Am 12.05.25 um 14:41 schrieb Fiona Ebner:
> The single-letter suffixes are ambiguous and especially in the context
> of disks, the powers of ten are usually used. Proxmox VE uses
> multiples of 1024 however. By adapting format_size() to use the verbose
> suffixes all newly written or re-written sizes will use the more
> verbose/explicit suffix.
> 
> The single-letter suffixes stay supported for backwards-compatibility
> for API/CLI users as well as parsing backup configurations. The
> function is currently also used for parsing the 'target-size' Ceph
> pool option (still restricted via schema to single-letter suffixes).
> 
> NOTE: maybe it makes sense to wait for PVE 9 with this and do a
> parse+write for all guest configs (including their snapshots) in
> the pve8to9 script?

I would split parsing and serialization so that we can apply the change
to parse_size for PVE 8 also, making the transition smoother and not
requiring any read-write all config steps, which would be a huge PITA
for users.

_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel