[pve-devel] [PATCH qemu-server] fix #3963: Skip TPM startup for template VMs

[pve-devel] [PATCH qemu-server] fix #3963: Skip TPM startup for template VMs

[Filip Schauer]

Skip the software TPM startup when starting a template VM for performing
a backup. This fixes an error that occurs when the TPM state disk is
write-protected.

Signed-off-by: Filip Schauer <f.schauer@proxmox.com>
---
 PVE/QemuServer.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index 484bc7f..5d7a92e 100644
--- a/PVE/QemuServer.pm
+++ b/PVE/QemuServer.pm
@@ -5923,7 +5923,7 @@ sub vm_start_nolock {
 	    PVE::Systemd::enter_systemd_scope($vmid, "Proxmox VE VM $vmid", %systemd_properties);
 
 	    my $tpmpid;
-	    if (my $tpm = $conf->{tpmstate0}) {
+	    if ((my $tpm = $conf->{tpmstate0}) && PVE::QemuConfig->is_template($conf)) {
 		# start the TPM emulator so QEMU can connect on start
 		$tpmpid = start_swtpm($storecfg, $vmid, $tpm, $migratedfrom);
 	    }
-- 
2.39.2

Re: [pve-devel] [PATCH qemu-server] fix #3963: Skip TPM startup for template VMs

[Thomas Lamprecht]

Am 09/08/2023 um 11:09 schrieb Filip Schauer:
> Skip the software TPM startup when starting a template VM for performing
> a backup. This fixes an error that occurs when the TPM state disk is
> write-protected.
> 
> Signed-off-by: Filip Schauer <f.schauer@proxmox.com>
> ---
>  PVE/QemuServer.pm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
> index 484bc7f..5d7a92e 100644
> --- a/PVE/QemuServer.pm
> +++ b/PVE/QemuServer.pm
> @@ -5923,7 +5923,7 @@ sub vm_start_nolock {
>  	    PVE::Systemd::enter_systemd_scope($vmid, "Proxmox VE VM $vmid", %systemd_properties);
>  
>  	    my $tpmpid;
> -	    if (my $tpm = $conf->{tpmstate0}) {
> +	    if ((my $tpm = $conf->{tpmstate0}) && PVE::QemuConfig->is_template($conf)) {
>  		# start the TPM emulator so QEMU can connect on start
>  		$tpmpid = start_swtpm($storecfg, $vmid, $tpm, $migratedfrom);
>  	    }


just for the record: this got superseded by a v2:
https://lists.proxmox.com/pipermail/pve-devel/2023-August/058691.html

and then later the v4 got applied:
https://lists.proxmox.com/pipermail/pve-devel/2023-August/058742.html

It's helpful to reply to a patch that it is obsolete (just something
short is more than enough), as the existence of a next patch revision
might have been overlooked by reviewers otherwise, letting them
potentially waste more time than required.