Re: [pve-devel] applied: [PATCH proxmox 1/2] notify: webhook: gotify: set Content-Length header

[Thomas Lamprecht <t.lamprecht@proxmox.com>]

Am 26.03.25 um 10:54 schrieb Lukas Wagner:
> On  2025-03-25 19:41, Thomas Lamprecht wrote:
>> FWIW, as it was already encoded in the commit message for posterity I'd
>> have been fine with the comment being a bit shorter, e.g., the link to
>> the RFC and the last line, but it did not bother me to care amending the
>> patch and it's not a clear-cut, or at least subjective, so just a nit.
> 
> The brief quote from the RFC gives good context on *why* the change should be done
> in a self-contained way without having to go to the RFC text and search for the correct
> paragraph. IMO it definitely makes sense to have it in the commit message.

Yes, that's why I explicitly state that it makes sense in the *commit*
message, but that doing that is enough compared to also having the full
thing permanently as *comment* in the code like you did...
Because if we would do that for all implementation details the code
will get unreadable quickly.


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel