Re: [pve-devel] [PATCH common v4 1/6] VM start timeout config parameter in backend

[Thomas Lamprecht <t.lamprecht@proxmox.com>]

for anyone wanting to pick this up:

high level: it should go into pve-guest-common

Am 05/01/2023 um 11:08 schrieb Daniel Tschlatscher:
> This allows setting the 'startoptions' property string in the config.
> For now this only implements the 'timeout' parameter but should be
> rather easily extensible and allow related VM start config options
> to be also configurable here.
> 
> Signed-off-by: Daniel Tschlatscher <d.tschlatscher@proxmox.com>
> ---
> 
> Changes from v3:
> * No changes
> 
>  src/PVE/JSONSchema.pm | 38 ++++++++++++++++++++++++++++++++++++++
>  1 file changed, 38 insertions(+)
> 
> diff --git a/src/PVE/JSONSchema.pm b/src/PVE/JSONSchema.pm
> index 527e409..64dc01b 100644
> --- a/src/PVE/JSONSchema.pm
> +++ b/src/PVE/JSONSchema.pm
> @@ -640,6 +640,17 @@ sub pve_verify_startup_order {
>      die "unable to parse startup options\n";
>  }
>  
> +register_format('start-options', \&pve_verify_startup_options);

would prefer `guest-start-options`, as we have starts for other things (e.g., ceph or
systemd services)

> +sub pve_verify_startup_options {
> +    my ($value, $noerr) = @_;
> +
> +    return $value if pve_parse_startup_options($value);
> +
> +    return undef if $noerr;
> +
> +    die "unable to parse vm start options\n";
> +}
> +
>  my %bwlimit_opt = (
>      optional => 1,
>      type => 'number', minimum => '0',
> @@ -748,6 +759,33 @@ PVE::JSONSchema::register_standard_option('pve-startup-order', {
>      typetext => '[[order=]\d+] [,up=\d+] [,down=\d+] ',
>  });
>  
> +sub pve_parse_startup_options {
> +    my ($value) = @_;
> +
> +    return undef if !$value;
> +
> +    my $res = {};
> +
> +    foreach my $p (split(/,/, $value)) {
> +	next if $p =~ m/^\s*$/;
> +
> +	if ($p =~ m/^timeout=(\d+)$/ && int($1) <= 86400) {
> +	    $res->{timeout} = $1;
> +	} else {
> +	    return undef;
> +	}
> +    }
> +
> +    return $res;
> +}
> +
> +register_standard_option('start-options', {
> +    description => "Start up options for the VM. This only allows setting the VM start timeout for now, which is the maximum VM startup timeout in seconds. The maximum value for timeout is 86400, the minimum 0, which disables the timeout completely. If timeout is unset, the timeout will either be the memory of the VM in GiBs or 30, depending on which is higher. If unset and hibernated, the value will at least be 300 seconds, with hugepages at least 150 seconds.",

please split to multiple lines with 100cc max each

> +    optional => 1,
> +    type => 'string', format => 'start-options',
> +    typetext => 'timeout=\d+',
> +});
> +
>  register_format('pve-tfa-secret', \&pve_verify_tfa_secret);
>  sub pve_verify_tfa_secret {
>      my ($key, $noerr) = @_;