From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: "Proxmox VE development discussion" <pve-devel@lists.proxmox.com>,
"Fabian Grünbichler" <f.gruenbichler@proxmox.com>
Subject: Re: [pve-devel] [RFC PATCH guest-common 1/2] ReplicationState: purge state from non local vms
Date: Fri, 3 Jun 2022 08:45:25 +0200 [thread overview]
Message-ID: <321ce789-67c3-53ab-4288-db297e9f6d15@proxmox.com> (raw)
In-Reply-To: <1654180326.vcply64b2j.astroid@nora.none>
Am 02/06/2022 um 16:33 schrieb Fabian Grünbichler:
>> Replicate vm 100 from node A to node B and C, and activate HA. When node
>> A dies, it will be relocated to e.g. node B and start replicate from
>> there. If node B now had an old state lying around for it's sync to node
>> C, it might delete the common base snapshots of B and C and cannot sync
>> again.
>>
>> Deleting the state for all non local guests fixes that issue, since it
>> always starts fresh, and the potentially existing old state cannot be
>> valid anyway since we just relocated the vm here (from a dead node).
>>
>> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> the logic seems sound, the state *is* invalid/outdated once the guest
> has been stolen..
>
> Reviewed-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
>
Thanks! @Dominik, can you please send a v2 with Fabian's R-b and the nit from
patch 1/2 addressed? thanks!
prev parent reply other threads:[~2022-06-03 6:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-24 11:41 Dominik Csapak
2022-05-24 11:41 ` [pve-devel] [PATCH guest-common 2/2] ReplicationState: deterministically order replication jobs Dominik Csapak
2022-05-25 14:30 ` Thomas Lamprecht
2022-05-27 6:23 ` Dominik Csapak
2022-05-27 7:22 ` Thomas Lamprecht
2022-05-24 11:43 ` [pve-devel] [RFC PATCH guest-common 1/2] ReplicationState: purge state from non local vms Dominik Csapak
[not found] ` <1654180326.vcply64b2j.astroid@nora.none>
2022-06-03 6:45 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=321ce789-67c3-53ab-4288-db297e9f6d15@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=f.gruenbichler@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox