Re: [pve-devel] [PATCH v2 manager 3/3] fix #2745: ui: backup: allow users to specify remove=1

[Fabian Ebner <f.ebner@proxmox.com>]

On 09.03.21 11:28, Fabian Ebner wrote:
> On 05.03.21 21:34, Thomas Lamprecht wrote:
>> On 03.03.21 12:50, Fabian Ebner wrote:
>>> A user with Datastore.AllocateSpace, VM.Audit, VM.Backup can already 
>>> remove
>>> backups from the GUI manually, so it shouldn't be a problem if they 
>>> can set
>>> the remove flag when starting a manual backup in the GUI.
>>>
>>> Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
>>> ---
>>>
>>> Changes from v1:
>>>      * Rebase on current master.
>>>      * Do not use the label 'Remove', because that is rather 
>>> confusing, instead
>>>        use 'Prune'.
>>>
>>>   www/manager6/window/Backup.js | 13 ++++++++++++-
>>>   1 file changed, 12 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/www/manager6/window/Backup.js 
>>> b/www/manager6/window/Backup.js
>>> index 615073f3..d5b585bb 100644
>>> --- a/www/manager6/window/Backup.js
>>> +++ b/www/manager6/window/Backup.js
>>> @@ -68,6 +68,17 @@ Ext.define('PVE.window.Backup', {
>>>               name: 'mailto',
>>>               emptyText: Proxmox.Utils.noneText,
>>>           },
>>> +        {
>>> +            xtype: 'proxmoxcheckbox',
>>> +            name: 'remove',
>>> +            checked: false,
>>> +            uncheckedValue: 0,
>>> +            fieldLabel: gettext('Prune'),
>>> +            autoEl: {
>>> +            tag: 'div',
>>> +            'data-qtip': gettext('Prune older backups afterwards'),
>>> +            },
>>> +        },
>>
>> I find this confusing in the case the storage has no prune settings 
>> configured and
>> also if there's one its intransparent as one cannot really tell which 
>> one.
>> So I'd maybe only enable (or show?) this if it can actually do 
>> something, and in
>> that case I'd also show the current settings (they could change in 
>> theory until
>> the job is submitted, but not the norm and still better than nothing).
>>
>>
> 
> I don't think there is an API call to GET the currently configured 
> vzdump properties yet. With that, we can set the other properties in the 
> manual backup window (mailto, compression, etc.) to their currently 
> configured values too. Also, if we pass along the previously retrieved 
> prune settings as an API param, there is no race.
> 

But the prune-backups parameter is restricted to root (maxfiles is too), 
so passing it along doesn't work for other users. Would it make sense to 
change that? One can already manually remove backups with 
Datastore.AllocateSpace and VM.Backup, so being able to set a 
(potentially) different prune-backups param doesn't seem to make a big 
difference to me. (Note, I don't say the user should be able to edit the 
prune-backups param in the manual backup UI.)

>>>           ],
>>>       });
>>> @@ -82,7 +93,7 @@ Ext.define('PVE.window.Backup', {
>>>               storage: storage,
>>>               vmid: me.vmid,
>>>               mode: values.mode,
>>> -            remove: 0,
>>> +            remove: values.remove,
>>>           };
>>>           if (values.mailto) {
>>>
>>
> 
> 
> _______________________________________________
> pve-devel mailing list
> pve-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
> 
>