public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Leo Nunner <l.nunner@proxmox.com>
Subject: Re: [pve-devel] [PATCH docs] vzdump: document the new cluster-wide config file
Date: Tue, 14 Feb 2023 11:06:58 +0100	[thread overview]
Message-ID: <31a05a3b-6132-93ca-837d-321d98c3548c@proxmox.com> (raw)
In-Reply-To: <20230209092705.29496-4-l.nunner@proxmox.com>

On 09/02/2023 10:27, Leo Nunner wrote:
> + change the wording from "Global configuration" to "Node-wide
> configuration"
> 
> Signed-off-by: Leo Nunner <l.nunner@proxmox.com>
> ---
> The wording was previously already changed by Fiona but hasn't been
> merged yet:
> 
> https://lists.proxmox.com/pipermail/pve-devel/2022-December/055123.html
> 
>  vzdump.adoc | 12 ++++++++----
>  1 file changed, 8 insertions(+), 4 deletions(-)
> 
> diff --git a/vzdump.adoc b/vzdump.adoc
> index ce46529..253f264 100644
> --- a/vzdump.adoc
> +++ b/vzdump.adoc
> @@ -473,13 +473,17 @@ entire process happens transparently from a user's point of view.
>  Configuration
>  -------------
>  
> -Global configuration is stored in `/etc/vzdump.conf`. The file uses a
> -simple colon separated key/value format. Each line has the following
> -format:
> +Node-wide configuration is stored in `/etc/vzdump.conf`. A cluster-wide
> +configuration can be found at `/etc/pve/vzdump.conf`. Note that this is merely
> +a fallback, and that the node-wide configuration always has higher precedence.

but node-specific configs do not take precedence over CLI? This is worded a bit
confusing, maybe go for something more explicit as, i.e., something along the
lines of:

For each option the order of precendence is, Job or CLI option, if not defined then
local node-specific config, if not defined there then datacenter wide config and
if not defined there the default documented in the API schema.

> +Options that are not set in the node-wide configuration will be taken from
> +the cluster configuration, and, if not set there either, will take the default
> +value. The files use a simple colon separated key/value format. Each line
> +has the following format:
>  
>   OPTION: value
>  
> -Blank lines in the file are ignored, and lines starting with a `#`
> +Blank lines in the files are ignored, and lines starting with a `#`
>  character are treated as comments and are also ignored. Values from
>  this file are used as default, and can be overwritten on the command
>  line.





      reply	other threads:[~2023-02-14 10:07 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-09  9:27 [pve-devel] [PATCH manager cluster docs] Introduce cluster-wide vzdump configuration Leo Nunner
2023-02-09  9:27 ` [pve-devel] [PATCH manager] fix #4235: vzdump: add cluster-wide configuration Leo Nunner
2023-02-09  9:27 ` [pve-devel] [PATCH cluster] fix #4234: " Leo Nunner
2023-03-03 15:33   ` Thomas Lamprecht
2023-02-09  9:27 ` [pve-devel] [PATCH docs] vzdump: document the new cluster-wide config file Leo Nunner
2023-02-14 10:06   ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=31a05a3b-6132-93ca-837d-321d98c3548c@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=l.nunner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal