Re: [pve-devel] [PATCH manager] ui: storage: zfs: set blocksize placeholder to 16k

[Fiona Ebner <f.ebner@proxmox.com>]

Am 29.01.24 um 15:42 schrieb Aaron Lauterer:
> to reflect current ZFS defaults.
> 
> Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
> ---
> unless I have missed it, we currently still show the old default as
> placeholder
> 
>  www/manager6/storage/ZFSPoolEdit.js | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/www/manager6/storage/ZFSPoolEdit.js b/www/manager6/storage/ZFSPoolEdit.js
> index b66d131a..a0141ba3 100644
> --- a/www/manager6/storage/ZFSPoolEdit.js
> +++ b/www/manager6/storage/ZFSPoolEdit.js
> @@ -103,7 +103,7 @@ Ext.define('PVE.storage.ZFSPoolInputPanel', {
>  	{
>  	    xtype: 'textfield',
>  	    name: 'blocksize',
> -	    emptyText: '8k',
> +	    emptyText: '16k',
>  	    fieldLabel: gettext('Block Size'),
>  	    allowBlank: true,
>  	},

Well, both values are (potentially) wrong, because it depends on the
setting the pool was created with. So maybe "use setting from zpool" or
similar? Orthogonal to the patch, but the option also misses proper
validation in frontend and backend.