public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Lukas Wagner <l.wagner@proxmox.com>
Subject: Re: [pve-devel] [PATCH manager 1/3] headerbar: use same height and padding for product name as PBS and PMG
Date: Fri, 21 Jul 2023 16:04:32 +0200	[thread overview]
Message-ID: <313fdf75-38dd-492d-8588-77fa445a7415@proxmox.com> (raw)
In-Reply-To: <20230721093910.254158-1-l.wagner@proxmox.com>

On 21/07/2023 11:39, Lukas Wagner wrote:
> This makes the header bar look a bit less cramped and ensures consistency
> if web interfaces are used side-by-side, e.g. on an ultrawide screen.> 
> Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
> ---
> 
> Notes:
>     Disadvantage: We loose 8px of vertical space. However, I really think
>     this is negligible.

well we could also meed in the middle, if having 32, 34 or 36 px is
enough to make it "less cramped"? As I don't like ranking subjective
design tuning over actual UX, and even if just 8 px, it adds up
(especially when then uses this change to argue adding some white space
padding elsewhere).

Also, Proxmox Backup Server, Proxmox Mail Gateway have a relatively
different base UI structure too, and we normally try only hard to keep
things consistent in the same product, not that it hurts on its own to
do so also between products, but that shouldn't be the sole argument.

Still some polishing is good, and all in all this can be fine, but as
said I'd check for a trade-off.




  parent reply	other threads:[~2023-07-21 14:04 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-21  9:39 Lukas Wagner
2023-07-21  9:39 ` [pve-devel] [PATCH manager 2/3] headerbar: show shortcut for search in emptyText Lukas Wagner
2023-07-21 13:31   ` Thomas Lamprecht
2023-07-21 14:04     ` Lukas Wagner
2023-07-21  9:39 ` [pve-devel] [PATCH manager 3/3] headerbar: center search box, make it adapt to the width of the browser Lukas Wagner
2023-07-21 13:54   ` Thomas Lamprecht
2023-07-21 14:54     ` Lukas Wagner
2023-07-21 14:04 ` Thomas Lamprecht [this message]
2023-07-24  8:25   ` [pve-devel] [PATCH manager 1/3] headerbar: use same height and padding for product name as PBS and PMG Lukas Wagner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=313fdf75-38dd-492d-8588-77fa445a7415@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=l.wagner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal