Re: [pve-devel] [RFC manager 0/5] GUI: Hardware comments

[Thomas Lamprecht <t.lamprecht@proxmox.com>]

On 14.02.22 15:01, Matthias Heiserer wrote:
> This series is a first attempt to fix 2672 by implementing editable comments
> that are displayed in the GUI and stored in the qemu config file. 

I know Dominik's comment suggests this features is "ack'd" but I'm really not
sure about that I'd ack it, at least not in such a overly general form that adds
such things every where. We already have the guest notes for general comments about
bios/machine/... settings, bug 2672 is actually only asking for giving nic's and
disks some tag-like property to allow humans easier to determine what it's used for.

> 
> It works, but there are several questions:
> 
> How should comments be displayed? (GUI)
>     I added a third column. IMO, this looks cleaner than the alternative of
>     appending the comment to the corresponding config values. However, it 
>     requires more space and some special logic.

No, I really would not go that way for now, especially as I don't want such
comments on every level, if they're more restricted and tag like they can
just be rendered with existing infra.

>     
> What to do when there is not enough space? (GUI)
>     Currently, this case is not handled. A possible solution would be to
>     wrap overflowing lines, but I'm not sure what opinions are on that.

see above, no special handling required.

>     
> Should comments of ineditable fields (EFI Disk) be editable? (GUI)
>     I suppose yes, but currently they are not.

no, one can only have one efidisk, so the admin cannot be confused by multiple
efi disk entries, so they don't require a comment, the general guest section
is already more than enough for this-

> 
> Currently missing are:
>     GUI: Comments in the wizard, i.e. when creating a VM, no comment can be set.

for disks maybe ok, at least since we can add multiple disks from the start now
already, for all else no, please don't overload the user with inputs fields which
most people never need.

>     Detaching disks voids their comment. Probably shouldn't happen, but seems
>         a tad complicated.

that is unrelated of comments, detaching disks voids a lot of stuff which isn't
ideal and is separate from such a series.

>     The GUI assumes comments (except memory, socket, bios,  machine, scsihw)
>         to be URIencoded. This could be verified server-side.

just restrict them to a simpler format and be done..

Something along [\w-]{,32} (check what we already use elsewhere first)

What's missing: container support.


patch submit tipp: if you group the filenames of the format-patch exported patches
by repo before letting git send-email process them, they'd be also ordered/grouped
by that in the MTA's thread view per default, making it easier to review/apply.