Re: [pve-devel] [PATCH container v2 06/11] alloc_disk: update vdisk_alloc optional arguments signature

[Fiona Ebner <f.ebner@proxmox.com>]

Am 11.02.25 um 17:08 schrieb Daniel Kral:
> Update the call to `PVE::Storage::vdisk_alloc` to the updated function
> signature, which moves the optional argument `$name` (as it may be
> passed as undefined), to the optional hash argument at the end of the
> argument list.
> 
> Signed-off-by: Daniel Kral <d.kral@proxmox.com>

Reviewed-by: Fiona Ebner <f.ebner@proxmox.com>

> ---
> changes since v1:
> - new!
> 
>  src/PVE/LXC.pm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm
> index c634b70..32a54a9 100644
> --- a/src/PVE/LXC.pm
> +++ b/src/PVE/LXC.pm
> @@ -2174,7 +2174,7 @@ sub alloc_disk {
>  	    $do_format = 1;
>  	}
>  
> -	$volid = PVE::Storage::vdisk_alloc($storecfg, $storage, $vmid, $format, undef, $size_kb);
> +	$volid = PVE::Storage::vdisk_alloc($storecfg, $storage, $vmid, $format, $size_kb);
>  
>  	format_disk($storecfg, $volid, $root_uid, $root_gid) if $do_format;
>      };



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel