Re: [pve-devel] [PATCH qemu-server v1 1/3] vga: allow live-migration with clipboard

[Fiona Ebner <f.ebner@proxmox.com>]

Am 19.11.25 um 3:17 PM schrieb Markus Frank:
> On 2025-11-17 17:43, Fiona Ebner wrote:
>> Am 17.11.25 um 5:41 PM schrieb Fiona Ebner:
>>> Am 17.11.25 um 5:28 PM schrieb Markus Frank:
>>>> The live-migration feature now works with qemu's upstream commit:
>>>> 5d56bff11e ("ui/vdagent: add migration support")
>>>>
>>>> Signed-off-by: Markus Frank <m.frank@proxmox.com>
>>>> ---
>>>>   src/PVE/API2/Qemu.pm   | 5 -----
>>>>   src/PVE/QemuMigrate.pm | 5 -----
>>>>   src/PVE/QemuServer.pm  | 2 +-
>>>>   3 files changed, 1 insertion(+), 11 deletions(-)
>>>>
>>>> diff --git a/src/PVE/API2/Qemu.pm b/src/PVE/API2/Qemu.pm
>>>> index 02f5caec..314b6a48 100644
>>>> --- a/src/PVE/API2/Qemu.pm
>>>> +++ b/src/PVE/API2/Qemu.pm
>>>> @@ -5267,11 +5267,6 @@ __PACKAGE__->register_method({
>>>>           my ($local_resources, $mapped_resources,
>>>> $missing_mappings_by_node) =
>>>>              
>>>> PVE::QemuMigrate::Helpers::check_local_resources($vmconf, $res-
>>>> >{running}, 1);
>>>>   -        my $vga = PVE::QemuServer::parse_vga($vmconf->{vga});
>>>> -        if ($res->{running} && $vga->{'clipboard'} && $vga-
>>>> >{'clipboard'} eq 'vnc') {
>>>> -            push $local_resources->@*, "clipboard=vnc";
>>>> -        }
>>>
>>> I suppose this depends on having machine version >= 10.1, or? (In any
>>> case QEMU binary version >= 10.1 but that is implied by machine
>>> version >= 10.1)
> 
> Yes, it needs QEMU version >= 10.1. However, when I set the machine
> version to < 10.1
> (tested with version 6.2), the migration still works fine and the
> clipboard still functions on the other node.
> It seems that the machine version is unrelated here.
> 
> I suppose it would be better to check the QEMU version using
> get_running_qemu_version, wouldn't it?

But what if the target node has an older binary version? It won't
understand the new data in the migration stream, right? Such changes to
the migration stream should always be protected by machine version AFAIK
and it smells like a bug in QEMU if it isn't protected like that in QEMU
internally.

Could you test what happens when the target is an older binary?


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel