From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Stoiko Ivanov <s.ivanov@proxmox.com>
Subject: [pve-devel] applied-series: [PATCH container v2 0/2] add test for LXC_NAME hosts entry and fix a minor glitch
Date: Wed, 14 Jun 2023 16:25:15 +0200 [thread overview]
Message-ID: <3083d4ad-61f2-5fbb-f81e-9e208b6c26bb@proxmox.com> (raw)
In-Reply-To: <20230614123325.4122277-1-s.ivanov@proxmox.com>
Am 14/06/2023 um 14:33 schrieb Stoiko Ivanov:
> v1->v2:
> * actually added the /etc/hosts from an alpine template (seems I
> fat-fingered a cp iniially) for patch 2 - sorry for the fuzz
>
> original cover-letter for v1:
> the patch from:
> https://lists.proxmox.com/pipermail/pve-devel/2023-June/057420.html
> broke the setup for templates which don't contain /etc/hosts.
> This was fixed in a follow-up by Thomas.
> Sorry for not noticing the broken tests (they are currently skipped if
> building with sbuild, which I used)!
>
> patch 2 adds an explicit test for the functionality in the patch
>
> While checking the output I noticed a small glitch with Test::MockModule
> in the snapshot-test.pm - which should be addressed with patch 1 of this
> series.
>
> Stoiko Ivanov (2):
> tests: fix small syntax glitch
> tests: add minimal test for LXC_NAME hosts entry
>
applied series, thanks!
prev parent reply other threads:[~2023-06-14 14:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-14 12:33 [pve-devel] " Stoiko Ivanov
2023-06-14 12:33 ` [pve-devel] [PATCH container v2 1/2] tests: fix small syntax glitch Stoiko Ivanov
2023-06-14 12:33 ` [pve-devel] [PATCH container v2 2/2] tests: add minimal test for LXC_NAME hosts entry Stoiko Ivanov
2023-06-14 14:25 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3083d4ad-61f2-5fbb-f81e-9e208b6c26bb@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=s.ivanov@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox