From: Fiona Ebner <f.ebner@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Friedrich Weber <f.weber@proxmox.com>
Subject: [pve-devel] applied: [PATCH storage] plugin: nfs, cifs: use volume qemu snapshot methods from dir plugin
Date: Mon, 4 Aug 2025 11:25:46 +0200 [thread overview]
Message-ID: <30508785-332d-4edc-a682-30d3e4a75d19@proxmox.com> (raw)
In-Reply-To: <20250731082538.31891-1-f.weber@proxmox.com>
Am 31.07.25 um 10:26 AM schrieb Friedrich Weber:
> Taking an offline snapshot of a VM on an NFS/CIFS storage with
> snapshot-as-volume-chain currently creates a volume-chain snapshot as
> expected, but taking an online snapshot unexpectedly creates a qcow2
> snapshot. This was also reported in the forum [1].
>
> The reason is that the NFS/CIFS plugins inherit the method
> volume_qemu_snapshot_method from the Plugin base class, whereas they
> actually behave similarly to the Directory plugin. To fix this,
> implement the method for the NFS/CIFS plugins and let it call the
> Directory plugin's implementation.
>
> [1] https://forum.proxmox.com/threads/168619/post-787374
>
> Signed-off-by: Friedrich Weber <f.weber@proxmox.com>
For the record, this was already applied:
https://git.proxmox.com/?p=pve-storage.git;a=commit;h=3c209eaeb755bd702eb34cfd49589359a21858cf
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2025-08-04 9:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-31 8:24 [pve-devel] " Friedrich Weber
2025-08-04 9:25 ` Fiona Ebner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=30508785-332d-4edc-a682-30d3e4a75d19@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=f.weber@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox