Re: [pve-devel] [PATCH manager v14 10/12] ui: add resource mapping view for directories

[Daniel Kral <d.kral@proxmox.com>]

One comment inline, else LGTM and with this addressed consider this as:

Reviewed-by: Daniel Kral <d.kral@proxmox.com>

On 3/4/25 12:58, Markus Frank wrote:
> Signed-off-by: Markus Frank <m.frank@proxmox.com>
> ---
> v14:
> * return HTML encoded comment
> 
>   www/manager6/Makefile         |  1 +
>   www/manager6/dc/Config.js     | 10 +++++++++
>   www/manager6/dc/DirMapView.js | 42 +++++++++++++++++++++++++++++++++++
>   3 files changed, 53 insertions(+)
>   create mode 100644 www/manager6/dc/DirMapView.js
> 
> diff --git a/www/manager6/Makefile b/www/manager6/Makefile
> index 4b8677e3..57c4d377 100644
> --- a/www/manager6/Makefile
> +++ b/www/manager6/Makefile
> @@ -189,6 +189,7 @@ JSSRC= 							\
>   	dc/RealmSyncJob.js				\
>   	dc/PCIMapView.js				\
>   	dc/USBMapView.js				\
> +	dc/DirMapView.js				\
>   	lxc/CmdMenu.js					\
>   	lxc/Config.js					\
>   	lxc/CreateWizard.js				\
> diff --git a/www/manager6/dc/Config.js b/www/manager6/dc/Config.js
> index 74728c83..2958fb88 100644
> --- a/www/manager6/dc/Config.js
> +++ b/www/manager6/dc/Config.js
> @@ -329,6 +329,16 @@ Ext.define('PVE.dc.Config', {
>   			    title: gettext('USB Devices'),
>   			    flex: 1,
>   			},
> +			{
> +			    xtype: 'splitter',
> +			    collapsible: false,
> +			    performCollapse: false,
> +			},
> +			{
> +			    xtype: 'pveDcDirMapView',
> +			    title: gettext('Directories'),
> +			    flex: 1,
> +			},
>   		    ],
>   		},
>   	    );
> diff --git a/www/manager6/dc/DirMapView.js b/www/manager6/dc/DirMapView.js
> new file mode 100644
> index 00000000..ff0ce633
> --- /dev/null
> +++ b/www/manager6/dc/DirMapView.js
> @@ -0,0 +1,42 @@
> +Ext.define('pve-resource-dir-tree', {
> +    extend: 'Ext.data.Model',
> +    idProperty: 'internalId',
> +    fields: ['type', 'text', 'path', 'id', 'description', 'digest'],
> +});
> +
> +Ext.define('PVE.dc.DirMapView', {
> +    extend: 'PVE.tree.ResourceMapTree',
> +    alias: 'widget.pveDcDirMapView',
> +
> +    editWindowClass: 'PVE.window.DirMapEditWindow',
> +    baseUrl: '/cluster/mapping/dir',
> +    mapIconCls: 'fa fa-folder',
> +    entryIdProperty: 'path',
> +
> +    store: {
> +	sorters: 'text',
> +	model: 'pve-resource-dir-tree',
> +	data: {},
> +    },
> +
> +    columns: [
> +	{
> +	    xtype: 'treecolumn',
> +	    text: gettext('ID/Node'),
> +	    dataIndex: 'text',
> +	    width: 200,
> +	},
> +	{
> +	    text: gettext('announce-submounts'),
> +	    dataIndex: 'announce-submounts',
> +	},

This could also be in an advanced section as most users probably don't 
want to disable this. I'm not sure about how much overhead setting 
submounts in FUSE adds, but it should probably be negligible enough.

> +	{
> +	    header: gettext('Comment'),
> +	    dataIndex: 'description',
> +	    renderer: function(value, _meta, record) {
> +		return Ext.String.htmlEncode(value ?? record.data.comment);
> +	    },
> +	    flex: 1,
> +	},
> +    ],
> +});



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel