Re: [pve-devel] [PATCH] run-env: fallback to all zero mac for interfaces without

[Christian Ebner <c.ebner@proxmox.com>]

On 7/11/25 10:27, Gabriel Goller wrote:
> On 11.07.2025 10:03, Christian Ebner wrote:
>> The installer assumes to have a valid mac address for all interfaces
>> as provided by the runtime env json file. Deserialization will fail
>> if this is not the case.
>>
>> In some cases, the interface might however not provide a valid MAC
>> address, for example the WWAN module without any SIM installed on
>> some laptops.
>>
>> Fix this by defaulting to an all zero MAC address if non is detected.
>>
>> Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
>> ---
>> Please note: Untested, but I can test it based on an iso installer on
>> affected hardware
>>
>> Proxmox/Install/RunEnv.pm | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/Proxmox/Install/RunEnv.pm b/Proxmox/Install/RunEnv.pm
>> index e4f0eb0..d7ee258 100644
>> --- a/Proxmox/Install/RunEnv.pm
>> +++ b/Proxmox/Install/RunEnv.pm
>> @@ -110,7 +110,7 @@ my sub query_netdevs : prototype() {
>>         $ifs->{$name} = {
>>             index => $index,
>>             name => $name,
>> -            mac => $mac,
>> +            mac => $mac // '00:00:00:00:00:00',
>>             state => uc($state),
>>         };
>>         $ifs->{$name}->{addresses} = \@valid_addrs if @valid_addrs;
> 
> To be honest I'd rather filter out this interface. A zeroed out mac is
> reserved for loopback interfaces and usually isn't routed.

Okay, given that it might be better to filter it out and log that.

Will send a v2 (including the subject prefix `pve-installer` I did 
forget on this patch)


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel