public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: "DERUMIER, Alexandre" <alexandre.derumier@groupe-cyllene.com>
To: "pve-devel@lists.proxmox.com" <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH pve-manager 2/4] add permissions management for "local" network zone
Date: Fri, 2 Jun 2023 14:18:59 +0000	[thread overview]
Message-ID: <2ff8f2f2ae3cc1cbbbe442e681c734518990f54c.camel@groupe-cyllene.com> (raw)
In-Reply-To: <4e03c5b89c3c7a3b6810bb9f5e4e87e751d3bc4f.camel@groupe-cyllene.com>

Le vendredi 02 juin 2023 à 12:21 +0000, DERUMIER, Alexandre a écrit :
> > should this als obe guarded by the type check like below? is there
> > anything that ensures that a 'local' zone doesn't already exist as
> > regular SDN-managed zone?
> 
> I was more thinking to forbid "local" name in sdn code in another
> patch,
> as sdn it's still in beta anyway, user could still rename zone
> manually
> in cfg.
> 
> if not, user will not be able to manage local bridges permissions.

Thinking about this, the sdn zone names are limited to 8 characters,

so I could simply use "localnetwork" or "localbridges" as name



  reply	other threads:[~2023-06-02 14:19 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-26  7:27 [pve-devel] [PATCH pve-manager 0/4] add vnet/localbridge permissions management Alexandre Derumier
2023-05-26  7:27 ` [pve-devel] [PATCH pve-manager 1/4] add vnet permissions panel Alexandre Derumier
2023-05-26  7:27 ` [pve-devel] [PATCH pve-manager 2/4] add permissions management for "local" network zone Alexandre Derumier
2023-06-02 11:39   ` Fabian Grünbichler
2023-06-02 12:21     ` DERUMIER, Alexandre
2023-06-02 14:18       ` DERUMIER, Alexandre [this message]
2023-05-26  7:27 ` [pve-devel] [PATCH pve-manager 3/4] api2: network: check permissions for local bridges Alexandre Derumier
2023-06-02 11:39   ` Fabian Grünbichler
2023-05-26  7:27 ` [pve-devel] [PATCH pve-manager 4/4] api2: network: check vlan " Alexandre Derumier
2023-06-02 11:39   ` Fabian Grünbichler
2023-06-02 12:32     ` DERUMIER, Alexandre

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2ff8f2f2ae3cc1cbbbe442e681c734518990f54c.camel@groupe-cyllene.com \
    --to=alexandre.derumier@groupe-cyllene.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal