From: Daniel Tschlatscher <d.tschlatscher@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: Re: [pve-devel] [PATCH v2 manager 1/2] GUI: HDEdit: check iothread by default
Date: Mon, 9 May 2022 17:13:39 +0200 [thread overview]
Message-ID: <2ff81078-14ff-ee7d-8ef6-ce6c684e2500@proxmox.com> (raw)
In-Reply-To: <20220428084449.144884-1-m.heiserer@proxmox.com>
I applied this patch in a few virtualized Proxmox instances. Existing
VM disk and controller settings were correctly applied, adding new
disks worked as expected.
I tried to find some settings combinations in the Editor panel that
would be wrong or nonsensical. Though, I couldn't find any problems
in this regard either.
I also ran a few (rather straightforward) benchmarks using fio and dd.
While fio write commands were only slightly faster, read benchmarks
were nearly twice as fast.
Writing with dd using IOThreads yielded a speed increase of about 50%
compared to a disk not using an IO thread.
Everything worked as advertised.
Tested-by: Daniel Tschlatscher <d.tschlatscher@proxmox.com>
On 4/28/22 10:44, Matthias Heiserer wrote:
> And move it from the advanced section to the always shown area.
>
> Because of the propertyStringSet call in onGetValues, existing VM
> show the correct iothread value.
>
> Especially in benchmarks, iothreads significantly improve IO performance.
>
> Signed-off-by: Matthias Heiserer <m.heiserer@proxmox.com>
> ---
>
> Changes from v1:
> set true by default instead of binding it
>
> www/manager6/qemu/HDEdit.js | 19 ++++++++++---------
> 1 file changed, 10 insertions(+), 9 deletions(-)
>
> diff --git a/www/manager6/qemu/HDEdit.js b/www/manager6/qemu/HDEdit.js
> index c643ee73..b9c5cc5c 100644
> --- a/www/manager6/qemu/HDEdit.js
> +++ b/www/manager6/qemu/HDEdit.js
> @@ -251,6 +251,16 @@ Ext.define('PVE.qemu.HDInputPanel', {
> reference: 'discard',
> name: 'discard',
> },
> + {
> + xtype: 'proxmoxcheckbox',
> + name: 'iothread',
> + fieldLabel: 'IO thread',
> + clearOnDisable: true,
> + bind: {
> + disabled: '{!isVirtIO && !isSCSI}',
> + },
> + value: true,
> + },
> );
>
> advancedColumn1.push(
> @@ -263,15 +273,6 @@ Ext.define('PVE.qemu.HDInputPanel', {
> disabled: '{isVirtIO}',
> },
> },
> - {
> - xtype: 'proxmoxcheckbox',
> - name: 'iothread',
> - fieldLabel: 'IO thread',
> - clearOnDisable: true,
> - bind: {
> - disabled: '{!isVirtIO && !isSCSI}',
> - },
> - },
> {
> xtype: 'proxmoxcheckbox',
> name: 'readOnly', // `ro` in the config, we map in get/set values
next prev parent reply other threads:[~2022-05-09 15:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-28 8:44 Matthias Heiserer
2022-04-28 8:44 ` [pve-devel] [PATCH v2 manager 2/2] GUI: OS defaults: use SCSI single as default controller Matthias Heiserer
2022-04-28 8:44 ` [pve-devel] [PATCH v2 qemu-server 1/1] Warn in GUI for unlikely iothread config Matthias Heiserer
2022-05-10 7:26 ` Fabian Ebner
2022-05-10 7:33 ` Fabian Ebner
2022-05-09 15:13 ` Daniel Tschlatscher [this message]
2022-05-10 7:26 ` [pve-devel] [PATCH v2 manager 1/2] GUI: HDEdit: check iothread by default Fabian Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2ff81078-14ff-ee7d-8ef6-ce6c684e2500@proxmox.com \
--to=d.tschlatscher@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox