From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: [pve-devel] applied: [PATCH manager] ui: qemu/Config: disable xtermjs and spice until status is loaded
Date: Tue, 20 Apr 2021 18:20:10 +0200 [thread overview]
Message-ID: <2f09aba4-2cd2-8200-1bfd-427a11100672@proxmox.com> (raw)
In-Reply-To: <20210420143545.11022-1-d.csapak@proxmox.com>
On 20.04.21 16:35, Dominik Csapak wrote:
> We enable/disable spice/xtermjs for the console button in the 'load'
> callback of the statusstore, depending on the vms capabilities,
> but until the first load there, the only safe option is novnc.
>
> So we have to disable xtermjs and spice on start, else a click on
> the button might open a window that cannot connect to the vm.
>
> a forum user probably triggered this:
> https://forum.proxmox.com/threads/unable-to-find-serial-interface-console-problem.87705
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> www/manager6/qemu/Config.js | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/www/manager6/qemu/Config.js b/www/manager6/qemu/Config.js
> index 10bf10a4..b5f8cc9c 100644
> --- a/www/manager6/qemu/Config.js
> +++ b/www/manager6/qemu/Config.js
> @@ -199,6 +199,8 @@ Ext.define('PVE.qemu.Config', {
> disabled: !caps.vms['VM.Console'],
> hidden: template,
> consoleType: 'kvm',
> + enableSpice: false,
> + enableXtermjs: false,
> consoleName: vm.name,
> nodename: nodename,
> vmid: vmid,
>
adding a comment could be nice to avoid people thinking to "clean this up" in the future.
Anyway, applied. Related in the widest sense:
I have an issue with the default opened console viewer, a VM always opens the xtermjs
one when IMO the spice viewer or noVNC one should be preferred.
Setup details
* windows VM
** display spice (qxl)
** serial port added
* datacenter options for console viewer set to html5
next prev parent reply other threads:[~2021-04-20 16:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-20 14:35 [pve-devel] " Dominik Csapak
2021-04-20 16:20 ` Thomas Lamprecht [this message]
2021-04-21 6:50 ` [pve-devel] applied: " Dominik Csapak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2f09aba4-2cd2-8200-1bfd-427a11100672@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox