From: Fiona Ebner <f.ebner@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>,
Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Hannes Duerr <h.duerr@proxmox.com>
Subject: Re: [pve-devel] [PATCH qemu-server 1/2] drive device: fix regression with missing '/dev/disk/by-id' paths
Date: Wed, 23 Jul 2025 15:19:30 +0200 [thread overview]
Message-ID: <2eed2008-ccdf-46b3-92da-7ffd02082051@proxmox.com> (raw)
In-Reply-To: <a8ec8527-73b6-458c-ac30-a0ce7dab6951@proxmox.com>
Am 23.07.25 um 3:12 PM schrieb Thomas Lamprecht:
> Am 23.07.25 um 14:56 schrieb Hannes Duerr:
>> it seems to me that the patch does not apply on the latest master. Does this patch require some other patch be build upon?
>
> It's mail. Some lines of the tests are longer than 998 and thus the mail
> server/list hard wraps them, making the diff invalid. Would need to be
> send as base64 encoded (or better handled by the list).
>
> Joining those lines manually makes it work though.
And apparently the line endings are different. Is that expected in such
a case? I'll resend as base64.
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-07-23 13:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-23 11:10 Fiona Ebner
2025-07-23 11:10 ` [pve-devel] [PATCH qemu-server 2/2] fix #6556: vm status: fix querying block stats Fiona Ebner
2025-07-23 12:51 ` [pve-devel] [PATCH qemu-server 1/2] drive device: fix regression with missing '/dev/disk/by-id' paths Hannes Duerr
2025-07-23 12:55 ` Hannes Duerr
2025-07-23 13:12 ` Thomas Lamprecht
2025-07-23 13:19 ` Fiona Ebner [this message]
2025-07-23 13:35 ` [pve-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2eed2008-ccdf-46b3-92da-7ffd02082051@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=h.duerr@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox