public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: "Proxmox VE development discussion" <pve-devel@lists.proxmox.com>,
	"Fabian Grünbichler" <f.gruenbichler@proxmox.com>
Subject: [pve-devel] applied: [PATCH qemu] fix #3728: handle machine without type
Date: Wed, 17 Nov 2021 17:20:43 +0100	[thread overview]
Message-ID: <2ea00283-e6ce-00c9-56fb-5dfa6cf2ac5d@proxmox.com> (raw)
In-Reply-To: <20211117094117.1872784-1-f.gruenbichler@proxmox.com>

On 17.11.21 10:41, Fabian Grünbichler wrote:
> libguestfs starts their helper VMs with `-machine accel=..` without a
> machine type, and our pve version suffix handling would segfault in that
> case. there might be other scripted use cases that are affected as well.
> 
> this regression was introduced with the rebase of our patch set on top
> of 6.1.0
> 
> Fixes: f376b2b9e2fc1f0c8f9c6275e96ede5f423c4126
> 
> Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
> ---
>  ...E-Allow-version-code-in-machine-type.patch | 22 ++++++++++---------
>  1 file changed, 12 insertions(+), 10 deletions(-)
> 
>

applied, thanks!




      parent reply	other threads:[~2021-11-17 16:20 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-17  9:41 [pve-devel] " Fabian Grünbichler
2021-11-17 10:38 ` Dominik Csapak
2021-11-17 16:20 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2ea00283-e6ce-00c9-56fb-5dfa6cf2ac5d@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=f.gruenbichler@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal