From: Aaron Lauterer <a.lauterer@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: Re: [pve-devel] [PATCH common, widget-toolkit, manager v4 0/7] fix #3893: make bridge vids configurable
Date: Wed, 2 Oct 2024 15:13:09 +0200 [thread overview]
Message-ID: <2e017424-6663-42c6-ac1c-e44d56f9803e@proxmox.com> (raw)
In-Reply-To: <20240729115540.191594-1-a.lauterer@proxmox.com>
a new v5 has been sent
https://lore.proxmox.com/pve-devel/20241002131157.227292-1-a.lauterer@proxmox.com/T/#t
On 2024-07-29 13:55, Aaron Lauterer wrote:
> since I only incorporated smaller suggested changes, I left the r-b and
> t-b in place.
>
> this version reworks a few parts since
> v3: incorporated @shannons recommendations, in detail:
> * improve regex with non-capturing group
> * reworked check if valid VLAN config in UI field check
> * small code style and spelling things
> * reworded UI explanation text for bridge vids
>
> v2:
> * renamed format in JSONSchema to a more generic `pve-vlan-id-or-range`
> * explicitly use spaces when writing interfaces file. This is one
> possible approach to deal with the fact, that the generic `-list`
> format will accept quite a few delimiters and we need spaces.
> * code style improvements such as naming the regex results.
> * add parameter verification to the web ui
>
> With the changes to the JSONSchema we can then work on using it too for
> the guest trunk option. This hasn't been started yet though.
>
> common: Aaron Lauterer (3):
> tools: add check_list_empty function
> fix #3893: network: add vlan id and range parameter definitions
> inotify: interfaces: make sure bridge_vids use space as separator
>
> src/PVE/INotify.pm | 2 +-
> src/PVE/JSONSchema.pm | 34 ++++++++++++++++++++++++++++++++++
> src/PVE/Tools.pm | 8 ++++++++
> 3 files changed, 43 insertions(+), 1 deletion(-)
>
>
> widget-toolkit: Aaron Lauterer (2):
> fix #3892: Network: add bridge vids field for bridge_vids
> Network: add explanation for bridge vids field
>
> src/node/NetworkEdit.js | 73 +++++++++++++++++++++++++++++++++++++++++
> src/node/NetworkView.js | 5 +++
> 2 files changed, 78 insertions(+)
>
>
> manager: Aaron Lauterer (2):
> fix #3893: api: network: add bridge_vids parameter
> fix #3893: ui: network: enable bridge_vids field
>
> PVE/API2/Network.pm | 15 ++++++++++++++-
> www/manager6/node/Config.js | 1 +
> 2 files changed, 15 insertions(+), 1 deletion(-)
>
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2024-10-02 13:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-29 11:55 Aaron Lauterer
2024-07-29 11:55 ` [pve-devel] [PATCH common v4 1/7] tools: add check_list_empty function Aaron Lauterer
2024-09-09 14:02 ` Fiona Ebner
2024-09-10 6:56 ` Aaron Lauterer
2024-07-29 11:55 ` [pve-devel] [PATCH common v4 2/7] fix #3893: network: add vlan id and range parameter definitions Aaron Lauterer
2024-09-10 9:21 ` Fiona Ebner
2024-07-29 11:55 ` [pve-devel] [PATCH common v4 3/7] inotify: interfaces: make sure bridge_vids use space as separator Aaron Lauterer
2024-09-10 9:37 ` Fiona Ebner
2024-07-29 11:55 ` [pve-devel] [PATCH widget-toolkit v4 4/7] fix #3892: Network: add bridge vids field for bridge_vids Aaron Lauterer
2024-07-29 11:55 ` [pve-devel] [PATCH widget-toolkit v4 5/7] Network: add explanation for bridge vids field Aaron Lauterer
2024-07-29 11:55 ` [pve-devel] [PATCH manager v4 6/7] fix #3893: api: network: add bridge_vids parameter Aaron Lauterer
2024-07-29 11:55 ` [pve-devel] [PATCH manager v4 7/7] fix #3893: ui: network: enable bridge_vids field Aaron Lauterer
2024-10-02 13:13 ` Aaron Lauterer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2e017424-6663-42c6-ac1c-e44d56f9803e@proxmox.com \
--to=a.lauterer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox