Re: [pve-devel] [PATCH common, widget-toolkit, manager v4 0/7] fix #3893: make bridge vids configurable

[Aaron Lauterer <a.lauterer@proxmox.com>]

a new v5 has been sent 
https://lore.proxmox.com/pve-devel/20241002131157.227292-1-a.lauterer@proxmox.com/T/#t

On  2024-07-29  13:55, Aaron Lauterer wrote:
> since I only incorporated smaller suggested changes, I left the r-b and
> t-b in place.
> 
> this version reworks a few parts since
> v3: incorporated @shannons recommendations, in detail:
> * improve regex with non-capturing group
> * reworked check if valid VLAN config in UI field check
> * small code style and spelling things
> * reworded UI explanation text for bridge vids
> 
> v2:
> * renamed format in JSONSchema to a more generic `pve-vlan-id-or-range`
> * explicitly use spaces when writing interfaces file. This is one
>    possible approach to deal with the fact, that the generic `-list`
>    format will accept quite a few delimiters and we need spaces.
> * code style improvements such as naming the regex results.
> * add parameter verification to the web ui
> 
> With the changes to the JSONSchema we can then work on using it too for
> the guest trunk option. This hasn't been started yet though.
> 
> common: Aaron Lauterer (3):
>    tools: add check_list_empty function
>    fix #3893: network: add vlan id and range parameter definitions
>    inotify: interfaces: make sure bridge_vids use space as separator
> 
>   src/PVE/INotify.pm    |  2 +-
>   src/PVE/JSONSchema.pm | 34 ++++++++++++++++++++++++++++++++++
>   src/PVE/Tools.pm      |  8 ++++++++
>   3 files changed, 43 insertions(+), 1 deletion(-)
> 
> 
> widget-toolkit: Aaron Lauterer (2):
>    fix #3892: Network: add bridge vids field for bridge_vids
>    Network: add explanation for bridge vids field
> 
>   src/node/NetworkEdit.js | 73 +++++++++++++++++++++++++++++++++++++++++
>   src/node/NetworkView.js |  5 +++
>   2 files changed, 78 insertions(+)
> 
> 
> manager: Aaron Lauterer (2):
>    fix #3893: api: network: add bridge_vids parameter
>    fix #3893: ui: network: enable bridge_vids field
> 
>   PVE/API2/Network.pm         | 15 ++++++++++++++-
>   www/manager6/node/Config.js |  1 +
>   2 files changed, 15 insertions(+), 1 deletion(-)
> 



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel