[pve-devel] [PATCH installer] unconfigured: move terminal size setting before starting debug shell

[pve-devel] [PATCH installer] unconfigured: move terminal size setting before starting debug shell

[Christoph Heiss]

Otherwise, when using the serial debug shell, the console size will be
0x0. This in turn breaks the TUI installer, as it cannot detect the size
properly.

It also adjust the size to the proper 80x24 instead of 80x25, as
advertised in the log message.

Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
---
 unconfigured.sh | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/unconfigured.sh b/unconfigured.sh
index cf7de83..b921fc2 100755
--- a/unconfigured.sh
+++ b/unconfigured.sh
@@ -194,6 +194,11 @@ busybox --install -s || true
 
 setupcon || echo "setupcon failed, TUI rendering might be garbled - $?"
 
+if [ "$serial" -ne 0 ]; then
+    echo "Setting terminal size to 80x24 for serial install"
+    stty columns 80 rows 24
+fi
+
 if [ $proxdebug -ne 0 ]; then
     /sbin/agetty -o '-p -- \\u' --noclear tty9 &
     printf "\nDropping in debug shell before starting installation\n"
@@ -215,11 +220,6 @@ setsid /sbin/agetty -a root --noclear tty3 &
 /usr/bin/proxmox-low-level-installer dump-env
 
 if [ $proxtui -ne 0 ]; then
-    if [ "$serial" -ne 0 ]; then
-        echo "Setting terminal size to 80x24 for serial install"
-        stty columns 80 rows 25
-    fi
-
     echo "Starting the TUI installer"
     /usr/bin/proxmox-tui-installer 2>/dev/tty2
 else
-- 
2.43.1

Re: [pve-devel] [PATCH installer] unconfigured: move terminal size setting before starting debug shell

[Thomas Lamprecht]

On 12/03/2024 12:59, Christoph Heiss wrote:
> Otherwise, when using the serial debug shell, the console size will be
> 0x0. This in turn breaks the TUI installer, as it cannot detect the size
> properly.

That's ok, but...

> 
> It also adjust the size to the proper 80x24 instead of 80x25, as
> advertised in the log message.

... why not going the opposite direction and change the log message,
or is there some reason to go for 24 rows?

Isn't 80x25 the standard VGA one?

Re: [pve-devel] [PATCH installer] unconfigured: move terminal size setting before starting debug shell

[Christoph Heiss]

On Mon, Mar 18, 2024 at 04:55:20PM +0100, Thomas Lamprecht wrote:
> On 12/03/2024 12:59, Christoph Heiss wrote:
> > Otherwise, when using the serial debug shell, the console size will be
> > 0x0. This in turn breaks the TUI installer, as it cannot detect the size
> > properly.
>
> That's ok, but...
>
> >
> > It also adjust the size to the proper 80x24 instead of 80x25, as
> > advertised in the log message.
>
> ... why not going the opposite direction and change the log message,
> or is there some reason to go for 24 rows?
>
> Isn't 80x25 the standard VGA one?

For VGA 80x25 is the standard size [0], yes.

But for serial consoles aka. VT10x emulated terminals it is actually
80x24 [1], which basically everything uses as reference. GRUB also uses
80x24 when used over a serial interface. It spits out 24 lines at least.

Probably should have noted that in the commit messages, sorry.

[0] https://www.kernel.org/doc/Documentation/svga.txt (`NORMAL_VGA`)
[1] https://vt100.net/dec/ek-vt100-tm-002.pdf (page 21, "Format")

[pve-devel] applied: [PATCH installer] unconfigured: move terminal size setting before starting debug shell

[Thomas Lamprecht]

On 12/03/2024 12:59, Christoph Heiss wrote:
> Otherwise, when using the serial debug shell, the console size will be
> 0x0. This in turn breaks the TUI installer, as it cannot detect the size
> properly.
> 
> It also adjust the size to the proper 80x24 instead of 80x25, as
> advertised in the log message.
> 
> Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
> ---
>  unconfigured.sh | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
>

applied, with the info and references you provided in your
reply massaged into the commit message, thanks!