From: Christoph Heiss <c.heiss@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>
Cc: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH installer] unconfigured: move terminal size setting before starting debug shell
Date: Mon, 18 Mar 2024 17:29:51 +0100 [thread overview]
Message-ID: <2dqxny745xctiglrnmjdpl2gsux5wzxmcp7yzq6j2bcbskgwgd@l5vclftdp667> (raw)
In-Reply-To: <54fbabd6-a722-4524-8dbd-fbda3442cacd@proxmox.com>
On Mon, Mar 18, 2024 at 04:55:20PM +0100, Thomas Lamprecht wrote:
> On 12/03/2024 12:59, Christoph Heiss wrote:
> > Otherwise, when using the serial debug shell, the console size will be
> > 0x0. This in turn breaks the TUI installer, as it cannot detect the size
> > properly.
>
> That's ok, but...
>
> >
> > It also adjust the size to the proper 80x24 instead of 80x25, as
> > advertised in the log message.
>
> ... why not going the opposite direction and change the log message,
> or is there some reason to go for 24 rows?
>
> Isn't 80x25 the standard VGA one?
For VGA 80x25 is the standard size [0], yes.
But for serial consoles aka. VT10x emulated terminals it is actually
80x24 [1], which basically everything uses as reference. GRUB also uses
80x24 when used over a serial interface. It spits out 24 lines at least.
Probably should have noted that in the commit messages, sorry.
[0] https://www.kernel.org/doc/Documentation/svga.txt (`NORMAL_VGA`)
[1] https://vt100.net/dec/ek-vt100-tm-002.pdf (page 21, "Format")
next prev parent reply other threads:[~2024-03-18 16:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-12 11:59 Christoph Heiss
2024-03-18 15:55 ` Thomas Lamprecht
2024-03-18 16:29 ` Christoph Heiss [this message]
2024-03-22 10:38 ` [pve-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2dqxny745xctiglrnmjdpl2gsux5wzxmcp7yzq6j2bcbskgwgd@l5vclftdp667 \
--to=c.heiss@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox