Re: [pve-devel] [PATCH qemu-server 1/2] migration: avoid migrating disk images multiple times

[Fiona Ebner <f.ebner@proxmox.com>]

Am 10.05.23 um 11:57 schrieb Aaron Lauterer:
> 
> 
> On 5/9/23 16:43, Fiona Ebner wrote:
>> Am 09.05.23 um 14:55 schrieb Aaron Lauterer:
>>>
>>> * Don't scan all storages and only look at disk images that are
>>> referenced in the config. With this, we should have removed most
>>> situations where aliases would happen, and a migration is less likely to
>>> fail, because a storage is not online.
>>
>> I do prefer this approach as it also fixes issues like "unavailable, but
>> enabled storage that's not even involved fails migration". And it's also
>> more intuitive.
>>
>> But if we really do that, we need to be careful: In particular, we need
>> to explicitly pick up volumes in the pending section (currently, that
>> does only happen via the implicit scanning). There might be similar
>> issues in other situations, but none that I'm aware of.
> 
> Thanks for the hint. I'll look into it. What could be such a scenario?
> Adding a new disk or removing one with hot-plugging not working?

Yes, disk hotplug can also be disabled and it doesn't work for all
controller types.