From: Fiona Ebner <f.ebner@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Maximiliano Sandoval <m.sandoval@proxmox.com>
Subject: Re: [pve-devel] [PATCH widget-toolkit] ui: repo status: Simplify logic for adding warnings
Date: Mon, 19 Feb 2024 13:46:11 +0100 [thread overview]
Message-ID: <2d7d27cb-57fd-408e-a493-d36f1ecb204e@proxmox.com> (raw)
In-Reply-To: <20231207131146.274773-1-m.sandoval@proxmox.com>
Am 07.12.23 um 14:11 schrieb Maximiliano Sandoval:
> The strings were hard to translate and required some tricks like passing
> 'Ceph ' as an argument. The `/main` part was also removed to simplify
> the flow and UX.
>
But people who have a Ceph repository with 'main' component configured
might be confused when getting a warning that only mentions
'no-subscription'.
It's only relevant for Ceph Quincy and it turns out that the warnings
are currently only displayed for Ceph Reef repositories, because the UI
doesn't expect multiple Ceph versions. So I'd be fine with dropping the
'/main' after all.
Could you take a stab at fixing handling for multiple Ceph versions in a
follow-up? I.e. fix updateStandardRepos() to detect which version is
actually configured and only consider the statuses from those, as well
as displaying a warning if there are mixed Ceph versions configured.
> Suggested-by: Dietmar Maurer <dietmar@proxmox.com>
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
Reviewed-by: Fiona Ebner <f.ebner@proxmox.com>
prev parent reply other threads:[~2024-02-19 12:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-07 13:11 Maximiliano Sandoval
2024-02-19 12:46 ` Fiona Ebner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2d7d27cb-57fd-408e-a493-d36f1ecb204e@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=m.sandoval@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox