From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Christoph Heiss <c.heiss@proxmox.com>
Subject: Re: [pve-devel] [PATCH installer] proxmox-chroot: replace nix::(u)mount calls with external (u)mount
Date: Fri, 4 Apr 2025 10:17:58 +0200 [thread overview]
Message-ID: <2cfd7c1a-8b67-49c6-b808-60ae76acb195@proxmox.com> (raw)
In-Reply-To: <20250311132733.820837-1-c.heiss@proxmox.com>
Am 11.03.25 um 14:27 schrieb Christoph Heiss:
> Comes with a reduction of 52 -> 40 in terms of crate dependencies for
> proxmox-chroot, 198 -> 192 for a full workspace build.
>
> Currently, this is done inconsistently anyway, i.e. there are calls to
> the external mount(8) as well as mount(2) and umount(2) via `nix`.
> Just switch over to calling the external programs completely, which in
> turn allows to drop the `nix` crate dependency from the tree.
I'm general a big fan of dropping crates (or using as many as needed but
as few as possible), but nix is a very general thing, actually I'm
surprised we do not use it more often; maybe if we would write more of
the actual installer in rust. OTOH, nothing limits us from reintroducing
this, and then handle mounting in a more consistent manner implementation
wise - so fine by me...
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-04-04 8:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-11 13:27 Christoph Heiss
2025-04-04 8:17 ` Thomas Lamprecht [this message]
2025-04-04 8:28 ` [pve-devel] applied: " Thomas Lamprecht
2025-04-04 8:39 ` Christoph Heiss
2025-04-04 11:37 ` [pve-devel] " Wolfgang Bumiller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2cfd7c1a-8b67-49c6-b808-60ae76acb195@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=c.heiss@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal