public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Fiona Ebner <f.ebner@proxmox.com>,
	Dominik Csapak <d.csapak@proxmox.com>,
	Markus Frank <m.frank@proxmox.com>
Subject: Re: [pve-devel] [PATCH manager v10 1/2] ui: machine: add viommu ComboBox
Date: Mon, 22 Apr 2024 19:58:09 +0200	[thread overview]
Message-ID: <2ce75ded-d687-4290-96f9-e13a3d021bd8@proxmox.com> (raw)
In-Reply-To: <998214a0-4aac-4372-944f-9c618e027cc7@proxmox.com>

Am 22/04/2024 um 15:24 schrieb Fiona Ebner:
> Am 22.04.24 um 15:16 schrieb Dominik Csapak:
>> On 4/22/24 15:11, Fiona Ebner wrote:
>>> Should we display some hint that Intel can/should also be used even if
>>> you have an AMD? Maybe even just in the text we display, like "Intel
>>> (also used for AMD)" but hope somebody can come up with something better.
>>
>> mhh.. i mean it is a virtual device, so should we also add this info
>> for e.g. e1000 devices?

Intel e1000 is a network card where no real relation to similar models from
AMD exist, nor is the network market a duopoly like the (x86_64) CPU market;
so this comparison does not really work IMO.

> Personally, I'd go in assuming the "Intel" setting is wrong with my AMD
> CPU and so might many users.
> 
>> since it's in the advanced section and it is documented in pve-docs,
>> i'd leave it out here (we can still add a notice later if users
>> are confused, but most users won't use/need it anyway)
> 
> Yes, we could also wait. But if the confusion can be avoided/reduced
> without much effort, I think it's worth doing up-front.

Yeah, definitively agreed, this is guaranteed to be a source of confusion
otherwise. I changed the display value to "Intel (AMD Compatible)".
Albeit now I'm thinking that it might have been slightly better to
lowercase "compatible", oh well..

https://git.proxmox.com/?p=pve-manager.git;a=commit;h=216398458d4be8781155f7d64835a38971258793


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


  reply	other threads:[~2024-04-22 17:58 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-15  8:50 Markus Frank
2024-04-15  8:50 ` [pve-devel] [PATCH manager v10 2/2] ui: machine: add link to documentation of the system settings Markus Frank
2024-04-22 13:13   ` Fiona Ebner
2024-04-22 13:18     ` Dominik Csapak
2024-04-22 13:19       ` Fiona Ebner
2024-04-22 13:21       ` Thomas Lamprecht
2024-04-22 13:22         ` Dominik Csapak
2024-04-22 13:11 ` [pve-devel] [PATCH manager v10 1/2] ui: machine: add viommu ComboBox Fiona Ebner
2024-04-22 13:16   ` Dominik Csapak
2024-04-22 13:24     ` Fiona Ebner
2024-04-22 17:58       ` Thomas Lamprecht [this message]
2024-04-22 13:11 ` [pve-devel] applied: " Dominik Csapak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2ce75ded-d687-4290-96f9-e13a3d021bd8@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=d.csapak@proxmox.com \
    --cc=f.ebner@proxmox.com \
    --cc=m.frank@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal