Re: [PATCH manager 5/7] ui: qga: add checkbox for guest-fsfreeze

[Fiona Ebner <f.ebner@proxmox.com>]

Am 25.02.26 um 4:47 PM schrieb Maximiliano Sandoval:
> We re-use the same components from the 'freeze-fs-on-backup' checkbox
> but without referencing that this only affects backups.
> 
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
> ---
>  www/manager6/form/AgentFeatureSelector.js | 28 +++++++++++++++++++++++
>  1 file changed, 28 insertions(+)
> 
> diff --git a/www/manager6/form/AgentFeatureSelector.js b/www/manager6/form/AgentFeatureSelector.js
> index e7fa929c..a3dda630 100644
> --- a/www/manager6/form/AgentFeatureSelector.js
> +++ b/www/manager6/form/AgentFeatureSelector.js
> @@ -21,6 +21,28 @@ Ext.define('PVE.form.AgentFeatureSelector', {
>              },
>              disabled: true,
>          },
> +        {
> +            xtype: 'proxmoxcheckbox',
> +            boxLabel: gettext('Freeze/thaw guest filesystems for consistency'),

I feel like "Freeze/thaw guest filesystems during certain disk
operations for consistency" would be a little more telling.

> +            name: 'guest-fsfreeze',
> +            reference: 'guest_fsfreeze',
> +            bind: {
> +                disabled: '{!enabled.checked}',
> +            },
> +            disabled: true,
> +            uncheckedValue: '0',
> +            defaultValue: '1',
> +        },
> +        {
> +            xtype: 'displayfield',
> +            userCls: 'pmx-hint',
> +            value: gettext(
> +                'Freeze/thaw for guest filesystems disabled. This can lead to inconsistent disk images.',

..."for certain operations"

> +            ),
> +            bind: {
> +                hidden: '{guest_fsfreeze.checked}',
> +            },
> +        },
>          {
>              xtype: 'displayfield',
>              userCls: 'pmx-hint',
> @@ -73,6 +95,9 @@ Ext.define('PVE.form.AgentFeatureSelector', {
>          if (PVE.Parser.parseBoolean(values['freeze-fs-on-backup'])) {
>              delete values['freeze-fs-on-backup'];
>          }
> +        if (PVE.Parser.parseBoolean(values['guest-fsfreeze'])) {
> +            delete values['guest-fsfreeze'];
> +        }
>  
>          const agentstr = PVE.Parser.printPropertyString(values, 'enabled');
>          return { agent: agentstr };
> @@ -83,6 +108,9 @@ Ext.define('PVE.form.AgentFeatureSelector', {
>          if (!Ext.isDefined(res['freeze-fs-on-backup'])) {
>              res['freeze-fs-on-backup'] = 1;
>          }
> +        if (!Ext.isDefined(res['guest-fsfreeze'])) {
> +            res['guest-fsfreeze'] = 1;
> +        }
>  
>          this.callParent([res]);
>      },